Skip to content

Implement CLRDataMethodDefinition IL extent APIs in cDAC#131384

Draft
rcj1 with Copilot wants to merge 4 commits into
mainfrom
copilot/implement-clrdata-methods
Draft

Implement CLRDataMethodDefinition IL extent APIs in cDAC#131384
rcj1 with Copilot wants to merge 4 commits into
mainfrom
copilot/implement-clrdata-methods

Conversation

Copilot AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Implements IL extent enumeration and representative entry-address lookup for CLRDataMethodDefinition, replacing legacy fallback behavior.

  • Implementation

    • Adds StartEnumExtents, EnumExtent, EndEnumExtents, and GetRepresentativeEntryAddress.
    • Preserves legacy DAC semantics for tiny/fat IL headers and single-shot enumeration.
    • Reads fixed-format IL fields as little-endian across target architectures.
  • Validation

    • Adds CanFallback() gates to legacy debug cross-validation.
    • Covers invalid arguments, missing IL, and tiny/extended-fat headers.

Note

This description was generated by GitHub Copilot.

Copilot AI and others added 3 commits July 26, 2026 02:50
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 26, 2026 03:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 26, 2026 03:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title Implement CLRDataMethodDefinition IL extents in cDAC Implement CLRDataMethodDefinition IL extent APIs in cDAC Jul 26, 2026
Copilot finished work on behalf of rcj1 July 26, 2026 03:07
Copilot AI requested a review from rcj1 July 26, 2026 03:07
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants