Skip to content

Implement CLRDataMethodInstance APIs in cDAC#131340

Draft
rcj1 with Copilot wants to merge 7 commits into
mainfrom
copilot/implement-getaddressrangesbyiloffset-and-getdefini
Draft

Implement CLRDataMethodInstance APIs in cDAC#131340
rcj1 with Copilot wants to merge 7 commits into
mainfrom
copilot/implement-getaddressrangesbyiloffset-and-getdefini

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Implements CLRDataMethodInstance.GetDefinition and GetAddressRangesByILOffset using cDAC contracts.

Changes

  • Method definitions

    • Resolves the defining module and metadata token from the MethodDesc.
    • Preserves legacy child-object fallback and debug HRESULT validation.
  • IL address ranges

    • Produces native ranges from debug-info IL mappings.
    • Matches native DAC buffer, epilog, and E_NOINTERFACE semantics.
    • Cross-validates results against the legacy DAC in debug builds.
  • Coverage

    • Adds dump tests for metadata resolution, matching address ranges, and missing IL offsets.

Copilot AI and others added 4 commits July 24, 2026 17:56
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI self-assigned this Jul 24, 2026
Copilot AI review requested due to automatic review settings July 24, 2026 18:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 23:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 23:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants