Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961608#127466

Open
dotnet-bot wants to merge 1 commit intomainfrom
locfiles/70732546-1126-4f8d-ad3a-3d85b61ba7b3
Open

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961608#127466
dotnet-bot wants to merge 1 commit intomainfrom
locfiles/70732546-1126-4f8d-ad3a-3d85b61ba7b3

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Copilot Code Review — PR #127466

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: This is an automated OneLocBuild localization check-in that provides translations for 4 previously untranslated diagnostic strings in the System.Text.Json source generator. The strings had state="new" targets (English placeholder text) that needed actual localized translations — this is routine and clearly justified.

Approach: Standard OneLocBuild pipeline output — replacing state="new" targets with state="translated" targets containing localized text across all 13 supported language files. This is the correct and expected approach.

Summary: ✅ LGTM. This is a straightforward, automated localization update with no source code, behavior, or API changes. All 13 language files are updated consistently, format string placeholders are preserved correctly, and the change is purely mechanical.


Detailed Findings

✅ Consistency — All 13 language files updated uniformly

Each of the 13 xlf files (cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant) updates the same 4 trans-units:

  • InaccessibleJsonIncludePropertiesNotSupportedFormat
  • InaccessibleJsonIncludePropertiesNotSupportedTitle
  • JsonIgnoreConditionAlwaysInvalidOnTypeFormat
  • JsonIgnoreConditionAlwaysInvalidOnTypeTitle

52 lines changed total: state="new"state="translated" (4 per language × 13 languages). No language file is missing or has extra changes.

✅ Format String Placeholders Preserved

Verified that the two format strings containing placeholders ({0}.{1} in InaccessibleJsonIncludePropertiesNotSupportedFormat and {0} in JsonIgnoreConditionAlwaysInvalidOnTypeFormat) correctly preserve all placeholders in every translated language. The 26 old lines with placeholders map to 26 new translated lines with matching placeholders.

✅ No Code, API, or Behavior Changes

This PR modifies only .xlf translation resource files. No source code, tests, public API surface, ref assemblies, or build configuration is affected. No new public API surface detected.

Generated by Code Review for issue #127466 ·

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961483 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961608 Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant