Allow O2K_CONST_VEC to handle all TYP_SIMD32/64#127401
Closed
tannergooding wants to merge 3 commits intodotnet:mainfrom
Closed
Allow O2K_CONST_VEC to handle all TYP_SIMD32/64#127401tannergooding wants to merge 3 commits intodotnet:mainfrom
tannergooding wants to merge 3 commits intodotnet:mainfrom
Conversation
Extend the O2K_CONST_VEC assertion storage to handle TYP_SIMD32/64 via a heap-allocated simd_t* (m_bigSimdVal) in the existing union. SIMD8/12/16 continue to use the inline simd16_t. The active SIMD byte size is tracked in m_simdSize, unioned with m_encodedIconFlags to keep struct size unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…equality Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends JIT assertion propagation support for SIMD constants beyond TYP_SIMD16, enabling assertions and constant propagation for TYP_SIMD32/64 (and recognizing additional SIMD equality/inequality patterns).
Changes:
- Extend
AssertionDscvector-constant storage to track SIMD payload size and support wider SIMD via arena allocation. - Update assertion creation/propagation to accept all SIMD constant types (
TYP_SIMD8/12/16/32/64) and compare based on payload size. - Enable assertion generation for
Vector256/Vector512equality/inequality intrinsics inoptAssertionGenJtrue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/coreclr/jit/compiler.h |
Updates assertion descriptor vector-constant representation (size + inline/allocated payload) and equality logic. |
src/coreclr/jit/assertionprop.cpp |
Expands assertion creation/propagation to all SIMD sizes and recognizes Vector256/512 EQ/NE patterns. |
Member
Author
|
Had been hoping to just get SPMI numbers, but it wouldn't build and I didn't have permission to push; so #127402 is a PR from my repo where I could include the jit-format and arm build fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #127390 which uses a heap allocation for SIMD values larger thatn
TYP_SIMD16.