[browser] Trigger library tests on WebAssembly SDK changes#127372
Open
maraf wants to merge 4 commits intodotnet:mainfrom
Open
[browser] Trigger library tests on WebAssembly SDK changes#127372maraf wants to merge 4 commits intodotnet:mainfrom
maraf wants to merge 4 commits intodotnet:mainfrom
Conversation
Remove src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/* from the wasm_specific_except_wbt_dbg exclude list so that changes to Microsoft.NET.Sdk.WebAssembly.Browser.targets (and other files in that directory) properly trigger browser library tests in CI. Also fix a YAML multi-line formatting bug where src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/ Sdk/WorkloadTesting.Core.targets was a continuation of the previous list item instead of its own entry in the exclude list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revert the targets file change and add a comment to GenerateWasmBootJson.cs to verify task source changes also trigger browser library tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was created with the help of GitHub Copilot.
Summary
Ensure browser library tests trigger in CI when
Microsoft.NET.Sdk.WebAssembly.Browser.targetsor related files in the WebAssembly SDK pack change.Changes
File:
eng/pipelines/common/evaluate-default-paths.ymlRemoved
src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/*from thewasm_specific_except_wbt_dbgexclude list — this path was already in the include set via_wasm_specific_only, but the exclusion prevented changes toMicrosoft.NET.Sdk.WebAssembly.Browser.targets(and sibling files) from triggering browser library tests.Fixed YAML multi-line formatting bug —
src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targetswas a continuation of the previous list item (missing-prefix) instead of its own entry in the exclude list, making it an ineffective exclude pattern.Task source paths (
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/*) already triggered browser library tests correctly — no change needed there.