Open
Conversation
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
commented
Mar 10, 2026
Comment on lines
+3742
to
+3744
| // exePath contains the full path to the executable. | ||
| MAKE_WIDEPTR_FROMUTF8(exePath, minipal_getexepath()); | ||
| SIZE_T commandLineLen = (u16_strlen(exePath) + 1); |
Member
Author
There was a problem hiding this comment.
This is a potential behavioral change. Now it will always use the executable path of current process, instead of exePath from coreclr_initialize. This is only used through ep_rt_diagnostics_command_line_get.
Comment on lines
+3690
to
+3693
| #ifdef TARGET_WINDOWS | ||
| // Use the result from GetCommandLineW() instead | ||
| pCmdLine = GetCommandLineW(); | ||
| #endif // HOST_WINDOWS |
Member
Author
There was a problem hiding this comment.
This could affect ep for hosted dll. In nativeaot /proc/self/cmdline is used.
What's the desired semantic here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.