Propagate NeverNegative flag during CSE#125272
Draft
EgorBo wants to merge 3 commits intodotnet:mainfrom
Draft
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR JIT to preserve “never negative” range information through CSE temps (enabling later range-check elimination), and adds new JIT metrics to track global assertion table usage (in addition to existing local assertion metrics).
Changes:
- Propagate
IsNeverNegativefrom a CSE candidate expression onto the newly-created CSE temp local. - Add
GlobalAssertionCount/GlobalAssertionOverflowmetrics and record them during global assertion propagation. - Change
optAssertionOverflowtype inCompiler(currently fromunsignedtoint).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/optcse.cpp | Propagates IsNeverNegative onto CSE temps to preserve non-negativity info for later bounds-check elimination. |
| src/coreclr/jit/jitmetadatalist.h | Adds new global-assertion metrics to the JIT metadata list. |
| src/coreclr/jit/compiler.h | Changes the type of optAssertionOverflow (used for assertion table overflow counting). |
| src/coreclr/jit/assertionprop.cpp | Records the new global-assertion metrics at the end of assertion discovery. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116073 (removes the bound check)
Also, add metrics to track global assertions (only the local ones were tracked before).