Re-enable Manual_CertificateOnlySentWhenValid_Success for WinHttpHandler#125262
Open
ManickaP wants to merge 1 commit intodotnet:mainfrom
Open
Re-enable Manual_CertificateOnlySentWhenValid_Success for WinHttpHandler#125262ManickaP wants to merge 1 commit intodotnet:mainfrom
ManickaP wants to merge 1 commit intodotnet:mainfrom
Conversation
Remove the WinHttpHandler skip for the client certificate test. The issue was reported in 2022 and it was unclear whether it was an environmental problem, a transient certificate issue, or an actual WinHttp bug. The test has not been reported as failing recently. Fixes dotnet#69238 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the Manual_CertificateOnlySentWhenValid_Success test for WinHttpHandler by removing the skip guard that had been added to work around issue #69238. That issue tracked intermittent WINHTTP_CALLBACK_STATUS_REQUEST_ERROR (error 12175) failures in CI when testing client certificate behavior in WinHttpHandler. The PR author validated the fix with 20 consecutive runs (0 failures) on both net11.0 and net481 TFMs.
Changes:
- Removes the
// [ActiveIssue("...")]comment that marked the test as having a known issue - Removes the
if (IsWinHttpHandler) throw new SkipTestException(...)guard that skipped the test for WinHttpHandler
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69238
Summary
Removes the
SkipTestExceptionguard that was disablingManual_CertificateOnlySentWhenValid_Successfor WinHttpHandler.Validation
Manual_CertificateOnlySentWhenValid_Successtests on Windows (both net11.0 and net481 TFMs).