[AVFoundation] Fix signature for LoadTrack*/LoadTracks* methods. Fixes #25606#25653
[AVFoundation] Fix signature for LoadTrack*/LoadTracks* methods. Fixes #25606#25653rolfbjarne wants to merge 8 commits into
Conversation
…ixes #25606. Fix the completion handler parameter types for LoadTrack/LoadTracksWithMediaType/ LoadTracksWithMediaCharacteristic methods in: - AVAsset (AVCompositionTrack -> AVAssetTrack) - AVMutableMovie (AVMovieTrack -> AVMutableMovieTrack) - AVFragmentedMovie (AVMutableCompositionTrack -> AVFragmentedMovieTrack) - AVComposition (AVMutableCompositionTrack -> AVCompositionTrack) Fixes #25606. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d signatures. Tests cover the new correctly-typed callback overloads for: - AVAsset.LoadTrack2, LoadTrackWithMediaCharacteristics, LoadTracksWithMediaType - AVMovie.LoadTrack, LoadTracksWithMediaType, LoadTracksWithMediaCharacteristic - AVMutableMovie.LoadTrack2, LoadTracksWithMediaType, LoadTracksWithMediaCharacteristic - AVComposition.LoadTrack, LoadTracksWithMediaType, LoadTracksWithMediaCharacteristic Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #1ad0603] Test results 🔥Test results❌ Tests failed on VSTS: test results 5 tests crashed, 92 tests failed, 76 tests passed. Failures❌ cecil tests1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
|
This comment has been minimized.
This comment has been minimized.
Move #if !__TVOS__ outside the #region directives so they nest properly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #44b99d8] Test results 🔥Test results❌ Tests failed on VSTS: test results 5 tests crashed, 93 tests failed, 75 tests passed. Failures❌ cecil tests1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ introspection tests1 tests failed, 5 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
|
This comment has been minimized.
This comment has been minimized.
…bsolete AVFoundation overloads. Teach bgen to read and emit [OverloadResolutionPriority(N)] from binding definitions. Apply [OverloadResolutionPriority(-1)] to the obsolete LoadTrack*/LoadTracks* overloads in AVFoundation that share their method name with the new typed-delegate overloads, resolving the overload ambiguity that prevented tests from building. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…validation. Add the attribute to the known-and-skipped list in the method attribute validation loop, fixing BI1007 'Unknown attribute' errors during binding generation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #2564a49] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #2564a49] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #2564a49] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #2564a49] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 16 tests failed, 204 tests passed. Failures❌ cecil tests [attempt 2]1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (tvOS) [attempt 2]15 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The completion handler callbacks for
LoadTrack*/LoadTracks*methods on several AVFoundation classes had incorrect parameter types (e.g.AVMutableCompositionTrackinstead ofAVMovieTrack).This PR:
XAMCORE_5_0)2suffix where naming conflicts arise due to delegate type inheritance relationships (AVAsset, AVMutableMovie)Affected classes:
AVAsset:LoadTrack2,LoadTrackWithMediaCharacteristics,LoadTracksWithMediaTypeAVMovie(category):LoadTrack,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicAVMutableMovie:LoadTrack2,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicAVFragmentedMovie(category):LoadTrack,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicAVComposition(category):LoadTrack,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicFixes #25606
🤖 Pull request created by Copilot