[CoreML] Remove the 'MLModelCollectionDidChangeNotification' field, it's not available anymore.#25277
[CoreML] Remove the 'MLModelCollectionDidChangeNotification' field, it's not available anymore.#25277rolfbjarne wants to merge 2 commits intomainfrom
Conversation
…t's not available anymore.
There was a problem hiding this comment.
Pull request overview
Removes the CoreML MLModelCollectionDidChangeNotification binding (no longer present in newer SDK headers) and adjusts related test ignore/documentation artifacts to keep the build and API validation checks consistent.
Changes:
- Remove
MLModelCollectionDidChangeNotificationfrom the CoreML binding definition and xtro ignore lists. - Add a managed-side shim for
MLModelCollectionnotification APIs under!XAMCORE_5_0. - Update documentation known-failures list for the newly introduced nested notifications type.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreML.ignore | Stop ignoring the removed CoreML notification field for macOS xtro runs. |
| tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreML.ignore | Stop ignoring the removed CoreML notification field for iOS xtro runs. |
| tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-CoreML.ignore | Stop ignoring the removed CoreML notification field for Mac Catalyst xtro runs. |
| tests/cecil-tests/Documentation.KnownFailures.txt | Adds a doc-known-failure entry for CoreML.MLModelCollection.Notifications. |
| src/frameworks.sources | Includes the new CoreML/MLModelCollection.cs file in CoreML sources. |
| src/coreml.cs | Removes the [Notification][Field] binding for MLModelCollectionDidChangeNotification. |
| src/CoreML/MLModelCollection.cs | Adds a compatibility shim for the removed notification members under !XAMCORE_5_0. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #383eefd] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #383eefd] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #383eefd] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #383eefd] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
No description provided.