[QuartzComposer] Replace RSS-related field bindings with manual code that returns null.#25271
[QuartzComposer] Replace RSS-related field bindings with manual code that returns null.#25271rolfbjarne wants to merge 2 commits intomainfrom
Conversation
…that returns null. These fields (QCCompositionInputRSSArticleDurationKey, QCCompositionInputRSSFeedURLKey, QCCompositionProtocolRSSVisualizer) have not been available at runtime since macOS 10.13 (which we no longer support), so remove them with manual code (that returns null) and obsolete them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the QuartzComposer bindings to handle three RSS-related QuartzComposer field constants that are no longer available at runtime on supported macOS versions by moving them to manual bindings that always return null, and updating introspection expectations accordingly.
Changes:
- Removed the RSS-related
[Field]entries fromsrc/quartzcomposer.csand replaced them with markers indicating manual bindings. - Added a new manual partial
QCCompositionimplementation that returnsnullfor the affected fields and obsoletes them. - Updated the macOS field introspection skip list (but currently in a way that will likely break the
FieldExiststest).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/introspection/MacApiFieldTest.cs | Adjusts which native field symbols are skipped during introspection validation. |
| src/quartzcomposer.cs | Removes the bgen [Field] bindings for the RSS-related constants and indicates manual handling. |
| src/frameworks.sources | Adds the new QuartzComposer manual source file to the build inputs. |
| src/QuartzComposer/QCComposition.cs | Introduces manual, obsolete, always-null properties for the removed RSS-related fields. |
| [BindingImpl (BindingImplOptions.GeneratedCode | BindingImplOptions.Optimizable)] | ||
| [Field ("QCCompositionInputRSSArticleDurationKey", "QuartzComposer")] | ||
| [ObsoletedOSPlatform ("macos10.14", "Use 'Metal' instead.")] |
There was a problem hiding this comment.
Leaving the [Field] attribute on these manual properties means the introspection FieldExists test will still try to resolve the native symbol via dlsym. If the symbol is intentionally absent on supported macOS, either remove the [Field] attribute (so it won't be validated as a native field), or keep [Field] and ensure MacApiFieldTest.Skip treats these symbol names as expected-missing.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #36adb73] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #36adb73] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #36adb73] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #36adb73] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 154 tests passed. Failures❌ interdependent-binding-projects tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
These fields (QCCompositionInputRSSArticleDurationKey,
QCCompositionInputRSSFeedURLKey, QCCompositionProtocolRSSVisualizer) have not
been available at runtime since macOS 10.13 (which we no longer support), so
remove them with manual code (that returns null) and obsolete them.