Skip to content

Include parameter name in ArgumentNullException for SDK version types #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Jun 1, 2026
Merged

Include parameter name in ArgumentNullException for SDK version types #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Xamarin.MacDev/AppleSdkVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public struct AppleSdkVersion : IComparable<AppleSdkVersion>, IEquatable<AppleSd
public AppleSdkVersion (Version version)
{
if (version == null)
throw new ArgumentNullException ();
throw new ArgumentNullException (nameof (version));

if (version.Build != -1) {
this.version = new int [3];
Expand Down
4 changes: 2 additions & 2 deletions Xamarin.MacDev/IPhoneSdkVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public struct IPhoneSdkVersion : IComparable<IPhoneSdkVersion>, IEquatable<IPhon
public IPhoneSdkVersion (Version version)
{
if (version == null)
throw new ArgumentNullException ();
throw new ArgumentNullException (nameof (version));

if (version.Build != -1) {
this.version = new int [3];
Expand All @@ -54,7 +54,7 @@ public IPhoneSdkVersion (Version version)
public IPhoneSdkVersion (params int [] version)
{
if (version == null)
throw new ArgumentNullException ();
throw new ArgumentNullException (nameof (version));

this.version = version;
}
Expand Down
4 changes: 2 additions & 2 deletions Xamarin.MacDev/MacOSXSdkVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public struct MacOSXSdkVersion : IComparable<MacOSXSdkVersion>, IEquatable<MacOS
public MacOSXSdkVersion (params int [] version)
{
if (version == null)
throw new ArgumentNullException ();
throw new ArgumentNullException (nameof (version));
this.version = version;
}

Expand All @@ -48,7 +48,7 @@ void IAppleSdkVersion.SetVersion (int [] version)
public MacOSXSdkVersion (Version version)
{
if (version == null)
throw new ArgumentNullException ();
throw new ArgumentNullException (nameof (version));
this.version = new [] { version.Major, version.Minor };
}

Expand Down
Loading