Bugfix :: Fix emitted method signatures: outref and static abstract byref params#19340
Open
Bugfix :: Fix emitted method signatures: outref and static abstract byref params#19340
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
codegen/fix-method-signatures
branch
3 times, most recently
from
88fbc57 to
3a393bd
Compare
Fix 4 codegen bugs in method call emission and parameter metadata: - #13468: outref parameter compiled as byref - #18135: Static abstract interface members with byref params - #18140: callvirt on value types causes ILVerify errors - #18374: RuntimeWrappedException cannot be caught Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
codegen/fix-method-signatures
branch
from
3a393bd to
4b98317
Compare
Static members implementing static abstract interface members with inref/outref parameters were missing the modreq(InAttribute)/modreq(OutAttribute) on their IL parameter types. This is because GetMethodSpecForMemberVal always used isSlotSig=false for static members, unlike instance members which check IsDispatchSlot and IsOverrideOrExplicitImpl. This caused the method def type signature to not match the override spec, leading to MethodDefNotFound errors (issue #18135). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove asymmetric Modified type stripping from MethodDefKey.Equals that incorrectly made Modified(_, _, T) == T, causing method deduplication and corrupt IL. Restrict Issue_18135 test to NET_CORE_APP since static abstract interface members require .NET 7+. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run fsharp-ci |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
changed the title
The more aggressive scope-aware type comparison for Byref/Boxed/Modified types may be causing incorrect method deduplication in CompressedMetadata mode, corrupting the VS extension DLL and causing 1820 NRE failures. This reverts just the ilwrite.fs change to test the hypothesis. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
codegen/fix-method-signatures
branch
from
e172d6b to
fd8cd07
Compare
Keep the outref [out] byref fix and slot sig param flags. Revert the GenILCall ccallInfo extension that added constrained. prefix for all struct callvirt — this is the likely cause of 1820 vs_release NRE failures on net472. Issue #18140 (constrained.callvirt) needs a different approach. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect method signatures in emitted IL.
outrefparameter from an interface method is compiled asbyrefparameter #13468 —outrefparameters now correctly emitted as[out] byrefinstead of plainbyrefFixes #18140— dropped: handled by #19372 Wave 2a with the correct approach (callinstead ofcallvirtfor value types).