-
Notifications
You must be signed in to change notification settings - Fork 841
Add Agent Framework DevUI into the aiagent-webapi template #7026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Agent Framework DevUI into the aiagent-webapi template #7026
Conversation
...emplates/Microsoft.Agents.AI.Templates.IntegrationTests/WebApiAgentTemplateExecutionTests.cs
Outdated
Show resolved
Hide resolved
| "dotnetRunMessages": true, | ||
| "launchBrowser": false, | ||
| "launchBrowser": true, | ||
| "launchUrl": "devui/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the trailing slash needed?
| .GetChatClient("gpt-4o-mini").AsIChatClient(); | ||
| var chatClient = new ChatClient( | ||
| "gpt-4o-mini", | ||
| new ApiKeyCredential(builder.Configuration["GitHubModels:Token"] ?? throw new InvalidOperationException("Missing configuration: GitHubModels:Token.")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use "GITHUB_TOKEN" for this config value? It seems like it's pretty common to use "GITHUB_TOKEN" for personal access tokens. For example, that's what the Aspire GitHub Models Integration looks for by default. And it's what GitHub Actions use for authentication in workflows. I get that the current config value is with the AI Chat Web App template currently uses.
danroth27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple of minor comments.
The Microsoft.Agents.AI.DevUI package will soon be published, and it will be enabled by default in the aiagent-webapi project template, with the option to disable it. When DevUI is enabled, the OpenAI Responses and Conversations need to be added into the app.
This PR also improves the project template execution test output to emit the stdout and stderr when not empty, as well as an expanded test description that does not get truncated (like the
[Theory]args do). As part of that, an issue is fixed in the project template projects where theExecutionTestSandboxfolders were being included in the projects, causing build errors in the projects after execution tests had been run.This cannot be merged until DevUI is published and the package versions are updated in
src/ProjectTemplates/GeneratedContent.targetsMicrosoft Reviewers: Open in CodeFlow