Add SQLite synchronous connection string option - #38812
Open
AhmedSadek10 wants to merge 2 commits into
Open
Conversation
- Add SqliteSynchronousMode and connection string support - Apply PRAGMA synchronous when opening connections - Add builder and connection tests Fixes dotnet#38769
Author
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull request overview
Adds configurable SQLite synchronous modes through connection strings and applies them when connections open.
Changes:
- Adds
SqliteSynchronousModeand builder support. - Applies
PRAGMA synchronousduring connection opening. - Adds API baseline and unit-test coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
SqliteSynchronousMode.cs |
Defines supported synchronous modes. |
SqliteConnectionStringBuilder.cs |
Adds the Synchronous option. |
SqliteConnection.cs |
Applies the configured pragma. |
Microsoft.Data.Sqlite.Core.baseline.json |
Records the new public API. |
SqliteConnectionTest.cs |
Tests modes on non-pooled connections. |
SqliteConnectionStringBuilderTest.cs |
Tests builder parsing and serialization. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Verify the native connection is reused after reopening - Verify the configured synchronous mode is reapplied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38769