Avoid using SqlXml for serialization#38506
Open
AndriySvyryd wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to #38462, changing SQL Server xml parameter handling to avoid wrapping XML in SqlXml (and its extra buffering) by sending an XmlReader directly to SqlClient, improving performance while keeping the SqlDbType.Xml path.
Changes:
- Switch
SqlServerStringTypeMappingto setSqlParameter.Valueto anXmlReaderforxmlstore type instead ofSqlXml. - Update
SqlServerQueryStringFactorysoToQueryString()can renderxmlparameters whose value is anXmlReader. - Adjust SQL Server tests to validate the new
XmlReaderparameter behavior and update related comments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/EFCore.SqlServer.Tests/Storage/SqlServerTypeMappingTest.cs | Updates unit test expectation from SqlXml to XmlReader for xml parameters. |
| test/EFCore.SqlServer.FunctionalTests/BuiltInDataTypesSqlServerTest.cs | Updates functional test comments around the xml parameter path exercised by the test. |
| src/EFCore.SqlServer/Storage/Internal/SqlServerStringTypeMapping.cs | Sends xml string values as a streaming XmlReader rather than buffering via SqlXml. |
| src/EFCore.SqlServer/Query/Internal/SqlServerQueryStringFactory.cs | Adds XmlReader handling to reconstruct a printable canonical xml literal for ToQueryString(). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38462 improving performance