Conversation
There was a problem hiding this comment.
Pull request overview
Re-enables the EF Core F# functional test project so it participates in the normal test build/run again, addressing the prior temporary disablement tracked in #34675.
Changes:
- Removed the unconditional test-skip flag from the F# functional test project.
- Removed the explicit
<None Include=...>entries that were used while the tests were disabled.
You can also share your feedback on Copilot code review. Take the survey.
Closes dotnet#34675
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <SkipTests Condition="'$(OS)' != 'Windows_NT' AND '$(Test__SqlServer__DefaultConnection)' == ''">true</SkipTests> |
There was a problem hiding this comment.
To match existing test project conventions, use True (capital T) for the <SkipTests> value (e.g. test/EFCore.SqlServer.FunctionalTests/EFCore.SqlServer.FunctionalTests.csproj:8). MSBuild is case-insensitive here, but keeping the same casing improves consistency across the repo.
| <SkipTests Condition="'$(OS)' != 'Windows_NT' AND '$(Test__SqlServer__DefaultConnection)' == ''">true</SkipTests> | |
| <SkipTests Condition="'$(OS)' != 'Windows_NT' AND '$(Test__SqlServer__DefaultConnection)' == ''">True</SkipTests> |
Closes #34675