Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

The LatencyPlugin schema enforced a maximum: 10000 constraint on maxMs, but the plugin code has never had such limit. Removes this artificial restriction from all schema versions.

Investigation Findings

  • The LatencyPlugin code has never enforced a maxMs limit (unchanged since initial commit bb09f96)
  • The limit was introduced in v0.25.0 (the first version with a latencyplugin schema)
  • The limit was present in all subsequent schema versions through v2.0.0

Changes

  • Removed "maximum": 10000 from maxMs property in all 13 schema versions (v0.25.0 through v2.0.0)
  • Updated descriptions in v0.27.0+ to remove reference to the "Max value is 10000 (10 seconds)" text
  • Versions v0.25.0 and v0.26.0 had no descriptions, so only the maximum constraint was removed
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove maxMs limit from LatencyPlugin schema</issue_title>
<issue_description>Raised from #1466

We don't have any logic in the LatencyPlugin that sets the maxMs to 10 seconds, but we have this set in the schema, we should remove the limit.

"maxMs": {
"type": "integer",
"minimum": 0,
"maximum": 10000,
"description": "The maximum amount of delay (in milliseconds) added to a request. Max value is 10000 (10 seconds). Default: 5000."
}
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: garrytrinder <11563347+garrytrinder@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove maxMs limit from LatencyPlugin schema Remove maxMs limit from LatencyPlugin schema Dec 3, 2025
Copilot AI requested a review from garrytrinder December 3, 2025 17:48
Copilot finished work on behalf of garrytrinder December 3, 2025 17:48
@waldekmastykarz
Copy link
Collaborator

@copilot check when this limit was lifted in the plugin (assuming it was ever there), identify the Dev Proxy version in which the change was included, and update all schemas starting from that version until now.

….0.0)

Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 4, 2025

@copilot check when this limit was lifted in the plugin (assuming it was ever there), identify the Dev Proxy version in which the change was included, and update all schemas starting from that version...

The LatencyPlugin code has never enforced a maxMs limit - it's been unchanged since the initial commit (bb09f96). The schema limit was introduced in v0.25.0 (the first version with a latencyplugin schema) and has been present in all subsequent versions.

I've updated all 13 schema versions from v0.25.0 through v2.0.0 to remove the artificial limit. See commit 159e5f9.

Copilot AI requested a review from waldekmastykarz December 4, 2025 09:10
Copilot finished work on behalf of waldekmastykarz December 4, 2025 09:10
@garrytrinder garrytrinder marked this pull request as ready for review December 4, 2025 09:56
@garrytrinder garrytrinder requested a review from a team as a code owner December 4, 2025 09:56
Copilot AI review requested due to automatic review settings December 4, 2025 09:56
Copilot finished reviewing on behalf of garrytrinder December 4, 2025 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an artificial maximum: 10000 constraint on the maxMs property from the LatencyPlugin schema across all 13 schema versions (v0.25.0 through v2.0.0). The constraint was never enforced in the actual LatencyPlugin code, which simply accepts any integer value for maxMs. Notably, the project's own m365.json config file uses maxMs: 10000, a value that was at the upper limit of the schema restriction.

Key changes:

  • Removed the "maximum": 10000 JSON schema constraint from all 13 schema versions
  • Updated property descriptions in v0.27.0+ to remove the misleading "Max value is 10000 (10 seconds)" text

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
schemas/v0.25.0/latencyplugin.schema.json Removed maximum constraint (no description existed in this version)
schemas/v0.26.0/latencyplugin.schema.json Removed maximum constraint (no description existed in this version)
schemas/v0.27.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v0.28.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v0.29.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v0.29.1/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v0.29.2/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v1.0.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v1.1.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v1.2.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v1.2.1/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v1.3.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value
schemas/v2.0.0/latencyplugin.schema.json Removed maximum constraint and updated description to remove reference to max value

@waldekmastykarz waldekmastykarz merged commit 4a41c76 into main Dec 4, 2025
12 checks passed
@waldekmastykarz waldekmastykarz deleted the copilot/remove-maxms-limit-latencyplugin branch December 4, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove maxMs limit from LatencyPlugin schema

3 participants