-
Notifications
You must be signed in to change notification settings - Fork 79
Remove maxMs limit from LatencyPlugin schema #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove maxMs limit from LatencyPlugin schema #1469
Conversation
Co-authored-by: garrytrinder <11563347+garrytrinder@users.noreply.github.com>
|
@copilot check when this limit was lifted in the plugin (assuming it was ever there), identify the Dev Proxy version in which the change was included, and update all schemas starting from that version until now. |
….0.0) Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
The LatencyPlugin code has never enforced a maxMs limit - it's been unchanged since the initial commit (bb09f96). The schema limit was introduced in v0.25.0 (the first version with a latencyplugin schema) and has been present in all subsequent versions. I've updated all 13 schema versions from v0.25.0 through v2.0.0 to remove the artificial limit. See commit 159e5f9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes an artificial maximum: 10000 constraint on the maxMs property from the LatencyPlugin schema across all 13 schema versions (v0.25.0 through v2.0.0). The constraint was never enforced in the actual LatencyPlugin code, which simply accepts any integer value for maxMs. Notably, the project's own m365.json config file uses maxMs: 10000, a value that was at the upper limit of the schema restriction.
Key changes:
- Removed the
"maximum": 10000JSON schema constraint from all 13 schema versions - Updated property descriptions in v0.27.0+ to remove the misleading "Max value is 10000 (10 seconds)" text
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/v0.25.0/latencyplugin.schema.json | Removed maximum constraint (no description existed in this version) |
| schemas/v0.26.0/latencyplugin.schema.json | Removed maximum constraint (no description existed in this version) |
| schemas/v0.27.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v0.28.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v0.29.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v0.29.1/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v0.29.2/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v1.0.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v1.1.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v1.2.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v1.2.1/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v1.3.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
| schemas/v2.0.0/latencyplugin.schema.json | Removed maximum constraint and updated description to remove reference to max value |
The LatencyPlugin schema enforced a
maximum: 10000constraint onmaxMs, but the plugin code has never had such limit. Removes this artificial restriction from all schema versions.Investigation Findings
Changes
"maximum": 10000frommaxMsproperty in all 13 schema versions (v0.25.0 through v2.0.0)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.