Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility#67136
Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility#67136Youssef1313 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the centrally-managed Swashbuckle.AspNetCore dependency version used across the repo, aligning the build’s external dependency set with a newer upstream release while the gRPC Swagger deprecation work (Issue #67134) is still pending.
Changes:
- Bump
Swashbuckle.AspNetCorefrom6.6.2to10.2.1viaeng/Versions.props.
wtgodbe
left a comment
There was a problem hiding this comment.
May need to kick off a run of https://dev.azure.com/dnceng/internal/_build?definitionId=931&_a=summary to get the package mirrored
Looks like it's already in dotnet-public since 2nd June. |
| <StackExchangeRedisVersion>2.7.27</StackExchangeRedisVersion> | ||
| <SystemReactiveLinqVersion>5.0.0</SystemReactiveLinqVersion> | ||
| <SwashbuckleAspNetCoreVersion>6.6.2</SwashbuckleAspNetCoreVersion> | ||
| <SwashbuckleAspNetCoreVersion>10.2.1</SwashbuckleAspNetCoreVersion> |
There was a problem hiding this comment.
This is multiple major (breaking change) releases upgrade. If we are impacted by too much breaking changes, it might not be worth spending the time to fix those. Waiting for CI to tell.
There was a problem hiding this comment.
The breaking changes should all be related to the upgrade from Microsoft.OpenApi v1 ➡️ v2.
|
@copilot Try to address the build errors in Microsoft.AspNetCore.Grpc.Swagger.Tests |
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility
Update Swashbuckle and align gRPC Swagger tests
Description
Updates
Swashbuckle.AspNetCoreto10.2.1while the work in #67134 is still pending.Also includes the follow-up fixes needed in
Microsoft.AspNetCore.Grpc.Swagger.Teststo match the newer OpenAPI surface used by the upgraded package, including the namespace change toMicrosoft.OpenApiand tag assertions that no longer rely on indexed access.