Skip to content

Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility#67136

Open
Youssef1313 wants to merge 3 commits into
mainfrom
dev/ygerges/update-swashbuckle
Open

Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility#67136
Youssef1313 wants to merge 3 commits into
mainfrom
dev/ygerges/update-swashbuckle

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Jun 10, 2026

Copy link
Copy Markdown
Member

Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Update Swashbuckle and align gRPC Swagger tests

Description

Updates Swashbuckle.AspNetCore to 10.2.1 while the work in #67134 is still pending.

Also includes the follow-up fixes needed in Microsoft.AspNetCore.Grpc.Swagger.Tests to match the newer OpenAPI surface used by the upgraded package, including the namespace change to Microsoft.OpenApi and tag assertions that no longer rely on indexed access.

@Youssef1313 Youssef1313 requested review from a team and wtgodbe as code owners June 10, 2026 17:55
@Youssef1313 Youssef1313 requested review from Copilot and halter73 June 10, 2026 17:55
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 10, 2026
@Youssef1313

Copy link
Copy Markdown
Member Author

cc @martincostello

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the centrally-managed Swashbuckle.AspNetCore dependency version used across the repo, aligning the build’s external dependency set with a newer upstream release while the gRPC Swagger deprecation work (Issue #67134) is still pending.

Changes:

  • Bump Swashbuckle.AspNetCore from 6.6.2 to 10.2.1 via eng/Versions.props.

@wtgodbe wtgodbe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to kick off a run of https://dev.azure.com/dnceng/internal/_build?definitionId=931&_a=summary to get the package mirrored

@Youssef1313

Youssef1313 commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

May need to kick off a run of https://dev.azure.com/dnceng/internal/_build?definitionId=931&_a=summary to get the package mirrored

Looks like it's already in dotnet-public since 2nd June.

Comment thread eng/Versions.props
<StackExchangeRedisVersion>2.7.27</StackExchangeRedisVersion>
<SystemReactiveLinqVersion>5.0.0</SystemReactiveLinqVersion>
<SwashbuckleAspNetCoreVersion>6.6.2</SwashbuckleAspNetCoreVersion>
<SwashbuckleAspNetCoreVersion>10.2.1</SwashbuckleAspNetCoreVersion>

@Youssef1313 Youssef1313 Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is multiple major (breaking change) releases upgrade. If we are impacted by too much breaking changes, it might not be worth spending the time to fix those. Waiting for CI to tell.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking changes should all be related to the upgrade from Microsoft.OpenApi v1 ➡️ v2.

@Youssef1313

Copy link
Copy Markdown
Member Author

@copilot Try to address the build errors in Microsoft.AspNetCore.Grpc.Swagger.Tests

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot Try to address the build errors in Microsoft.AspNetCore.Grpc.Swagger.Tests

Addressed in 6e4680f. The Grpc Swagger test project now uses the newer Microsoft.OpenApi namespace and no longer assumes swagger.Tags is indexable under the updated OpenAPI surface.

Copilot AI changed the title Update Swashbuckle.AspNetCore to latest Update Swashbuckle.AspNetCore and fix gRPC Swagger test compatibility Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants