DRAFT: Update to net11 - #1197
Conversation
bad7cd3 to
a351ab3
Compare
|
ACK. Thanks for putting this together. I'm out of town this weekend, but I'll look at this ASAP. |
6fdb7f2 to
d21204a
Compare
d21204a to
f00db0e
Compare
|
PR is green. @commonsensesoftware Hopefully the new API is good enough for your needs :) |
|
@Youssef1313 this is great. I've been able to incorporate this work into dev/css/v11. In reviewing where everything stands, there was only one open design issue remaining. Is it still feasible to unseal If you look at: It's pretty gross. 🤮 There is a relationship between the built-in options and the versioned equivalent. Since It's not a dealbreaker, but if this small change could be made, now is the time. I know you must be entering the RC milestone, but there is no functional change. I would just need the type unsealed. Aside from this one issue, I think I have most everything aligned for the RC and eventual release. Let me know. Thanks. |
|
@commonsensesoftware I doubt this will fit in .NET 11 timeframe as we are late in the cycle now. RC1 is already code complete, and this will need to go through the API review process. Feel free to open an API proposal, but I feel it's unlikely to change because:
|
|
@Youssef1313 Thanks. Yeah, I was afraid of that. If you don't think anyone will move, they almost certainly won't. I've filed legitimate bugs that have been open for 5+ years. This would be low on the totem pole. The current situation is less an alternative and more like hack. I can live with it, but it would have been better. Interesting that unsealing would require a full API review since the API doesn't change. I get the desire for more performance, but there should be a really compelling reason to apply I'll leave this PR open until I have the official branch merged. Thanks again for the assist. |
{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)