Skip to content

[main] Update dependencies from dotnet/arcade-services, dotnet/dnceng - #17348

Open
dotnet-maestro[bot] wants to merge 2 commits into
mainfrom
darc-main-6bc36683-4e63-43b5-8884-2f3c0d82e2bc
Open

[main] Update dependencies from dotnet/arcade-services, dotnet/dnceng#17348
dotnet-maestro[bot] wants to merge 2 commits into
mainfrom
darc-main-6bc36683-4e63-43b5-8884-2f3c0d82e2bc

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade-services

From https://github.com/dotnet/dnceng

…ild 20260813.1

On relative base path root
Microsoft.DotNet.DarcLib , Microsoft.DotNet.ProductConstructionService.Client From Version 1.1.0-beta.26374.1 -> To Version 1.1.0-beta.26413.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/arcade-services [main] Update dependencies from dotnet/arcade-services, dotnet/dnceng Aug 17, 2026
…814.1

On relative base path root
Microsoft.DncEng.SecretManager From Version 1.1.0-beta.26407.1 -> To Version 1.1.0-beta.26414.1
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

Summary — The dependency bump of Microsoft.DotNet.ProductConstructionService.Client from 1.1.0-beta.26374.1 to 1.1.0-beta.26413.1 introduced a breaking API change in GetBuildAsync: a new bool? includeAssetLocation parameter was inserted as the second positional argument (before CancellationToken), causing two CS1503 type-mismatch errors in PublishBuildToMaestro.cs.

Root cause: GetBuildAsync signature change — new bool? parameter before CancellationToken

The new Microsoft.DotNet.ProductConstructionService.Client package changed IBuildClient.GetBuildAsync from:

Task<Build> GetBuildAsync(int id, CancellationToken cancellationToken = default);

to:

Task<Build> GetBuildAsync(int id, bool? includeAssetLocation = default, CancellationToken cancellationToken = default);

The two call sites in PublishBuildToMaestro.cs pass cancellationToken as the second positional argument, which now binds to bool? instead of CancellationToken.

Affected errors

Code File:Line Message
CS1503 PublishBuildToMaestro.cs:362 Argument 2: cannot convert from System.Threading.CancellationToken to bool?
CS1503 PublishBuildToMaestro.cs:380 Argument 2: cannot convert from System.Threading.CancellationToken to bool?

Proposed fix

In src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishBuildToMaestro.cs, change both call sites to use the named cancellationToken: parameter (this also passes null/default for the new includeAssetLocation parameter, which is the appropriate behavior):

// Line 362
-                    producingBuild = await client.Builds.GetBuildAsync(asset.BuildId, cancellationToken);
+                    producingBuild = await client.Builds.GetBuildAsync(asset.BuildId, cancellationToken: cancellationToken);

// Line 380
-            var build = await client.Builds.GetBuildAsync(buildId.Value, cancellationToken);
+            var build = await client.Builds.GetBuildAsync(buildId.Value, cancellationToken: cancellationToken);

Note: PublishBuildToMaestro.cs is not part of this PR's diff — the fix needs to be committed separately (e.g., pushed to this branch by a maintainer, or merged as an additional commit alongside the dependency update).


Build overview
  • Build: FAILED (108.5s)
  • MSBuild: 18.9.0-preview
  • Projects: 82 total, 3 failed
  • Failed projects: Build.projArcade.slnxMicrosoft.DotNet.Build.Tasks.Feed.csproj
  • Errors: 3 (2× CS1503 + top-level "Build failed.")
  • Both Linux Debug and Windows Release legs failed with identical errors
All MSBuild errors (2)
Code Project File:Line Message
CS1503 Microsoft.DotNet.Build.Tasks.Feed PublishBuildToMaestro.cs:362 Argument 2: cannot convert from System.Threading.CancellationToken to bool?
CS1503 Microsoft.DotNet.Build.Tasks.Feed PublishBuildToMaestro.cs:380 Argument 2: cannot convert from System.Threading.CancellationToken to bool?

🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit d191eb4

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow.{ai_credits_suffix} · [◷]( · )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants