Add XA0119 warning for Debug builds with PublishReadyToRun#11213
Open
Add XA0119 warning for Debug builds with PublishReadyToRun#11213
Conversation
Add XA0119_ReadyToRun warning that fires when PublishReadyToRun is set in a Debug/fast-deployment configuration, matching the existing pattern for AotAssemblies. Update Resources.resx, Resources.Designer.cs, Xamarin.Android.Common.targets, and xa0119.md documentation. Agent-Logs-Url: https://github.com/dotnet/android/sessions/6cdbfb09-1398-4fbd-b5b5-111ce3992917 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jonathanpeppers
April 24, 2026 19:45
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new XA0119 warning variant to discourage combining fast deployment with ReadyToRun, aligning this guidance with existing XA0119 checks for AOT/linking, and updates the corresponding docs/resources.
Changes:
- Added
XA0119_ReadyToRunlocalized resource and generated accessor. - Added a new
AndroidWarningentry under_CheckNonIdealAppConfigurationsto emit XA0119 whenPublishReadyToRunis enabled with fast deployment. - Updated XA0119 documentation to mention
PublishReadyToRunguidance for Debug vs Release.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets | Adds XA0119 warning emission condition for PublishReadyToRun + fast deployment. |
| src/Xamarin.Android.Build.Tasks/Properties/Resources.resx | Adds the XA0119_ReadyToRun warning message. |
| src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs | Adds the generated property accessor for the new resource string. |
| Documentation/docs-mobile/messages/xa0119.md | Documents PublishReadyToRun as non-ideal for Debug/fast deployment and recommended for Release (CoreCLR). |
Files not reviewed (1)
- src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs: Language not supported
jonathanpeppers
approved these changes
Apr 24, 2026
jonathanpeppers
added
the
ready-to-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
XA0119warning variant (XA0119_ReadyToRun) that fires whenPublishReadyToRunis enabled in a Debug/fast-deployment configuration, matching the existing pattern forAotAssemblies/RunAOTCompilation.The warning message is:
Changes
Resources.resx— AddedXA0119_ReadyToRunresource stringResources.Designer.cs— Added correspondingXA0119_ReadyToRunpropertyXamarin.Android.Common.targets— AddedAndroidWarningin_CheckNonIdealAppConfigurationstarget with conditionEmbedAssembliesIntoApk != 'True' And PublishReadyToRun == 'True'xa0119.md— Updated documentation to listPublishReadyToRunin both the "remove from Debug" and "use for Release" sections