[xabt] Validate extracted zip entry paths in ExtractJarsFromAar#11212
Draft
jonathanpeppers wants to merge 1 commit intomainfrom
Draft
[xabt] Validate extracted zip entry paths in ExtractJarsFromAar#11212jonathanpeppers wants to merge 1 commit intomainfrom
ExtractJarsFromAar#11212jonathanpeppers wants to merge 1 commit intomainfrom
Conversation
This is just for correctness; there's no security enforcement here. Add `IsUnderDirectory` check at both extraction points (jars and annotations) to silently skip zip entries whose resolved path escapes the target directory. Logs a debug message when an entry is skipped. Add `ExtractJarsFromAarTests` with cases for jar traversal, annotations traversal, and a valid jar entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for correctness; there's no security enforcement here.
Add
IsUnderDirectorycheck at both extraction points (jars and annotations) to silently skip zip entries whose resolved path escapes the target directory. Logs a debug message when an entry is skipped.Add
ExtractJarsFromAarTestswith cases for jar traversal, annotations traversal, and a valid jar entry.