-
Notifications
You must be signed in to change notification settings - Fork 568
[dotnet test] Add androidtest project template and dotnet run instrumentation support
#10862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jonathanpeppers
wants to merge
5
commits into
main
Choose a base branch
from
dev/peppers/androidtest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
728114f
[dotnet test] Add `androidtest` project template and `dotnet run` ins…
jonathanpeppers f121c7c
`--user`
jonathanpeppers c7eb96b
Use `ProcessUtils` and async
jonathanpeppers 1afca66
Pass in CancellationToken
jonathanpeppers 2a62e8c
[xabt] Handle native PE files in HasMonoAndroidReference
jonathanpeppers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| using System.Diagnostics; | ||
| using Xamarin.Android.Tools; | ||
|
|
||
| static class AdbHelper | ||
| { | ||
| public static ProcessStartInfo CreateStartInfo (string adbPath, string? adbTarget, string arguments) | ||
| { | ||
| var fullArguments = string.IsNullOrEmpty (adbTarget) ? arguments : $"{adbTarget} {arguments}"; | ||
| return new ProcessStartInfo { | ||
| FileName = adbPath, | ||
| Arguments = fullArguments, | ||
| UseShellExecute = false, | ||
| RedirectStandardOutput = true, | ||
| RedirectStandardError = true, | ||
| CreateNoWindow = true, | ||
| }; | ||
| } | ||
|
|
||
| public static async Task<(int ExitCode, string Output, string Error)> RunAsync (string adbPath, string? adbTarget, string arguments, CancellationToken cancellationToken, bool verbose = false) | ||
| { | ||
| var psi = CreateStartInfo (adbPath, adbTarget, arguments); | ||
|
|
||
| if (verbose) | ||
| Console.WriteLine ($"Running: adb {psi.Arguments}"); | ||
|
|
||
| using var stdout = new StringWriter (); | ||
| using var stderr = new StringWriter (); | ||
| var exitCode = await ProcessUtils.StartProcess (psi, stdout, stderr, cancellationToken); | ||
|
|
||
| return (exitCode, stdout.ToString (), stderr.ToString ()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/Microsoft.Android.Templates/androidtest/.template.config/template.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "$schema": "http://json.schemastore.org/template", | ||
| "author": "Microsoft", | ||
| "classifications": [ "Android", "Mobile", "Test" ], | ||
| "identity": "Microsoft.Android.AndroidTest", | ||
| "name": "Android Test Project", | ||
| "description": "A project for creating a .NET for Android test project using MSTest", | ||
| "shortName": "androidtest", | ||
| "tags": { | ||
| "language": "C#", | ||
| "type": "project" | ||
| }, | ||
| "sourceName": "AndroidTest1", | ||
| "preferNameDirectory": true, | ||
| "primaryOutputs": [ | ||
| { "path": "AndroidTest1.csproj" } | ||
| ], | ||
| "symbols": { | ||
| "packageName": { | ||
| "type": "parameter", | ||
| "description": "Overrides the package name in the AndroidManifest.xml", | ||
| "datatype": "string", | ||
| "replaces": "com.companyname.AndroidTest1" | ||
| }, | ||
| "supportedOSVersion": { | ||
| "type": "parameter", | ||
| "description": "Overrides $(SupportedOSPlatformVersion) in the project", | ||
| "datatype": "string", | ||
| "replaces": "SUPPORTED_OS_PLATFORM_VERSION", | ||
| "defaultValue": "24" | ||
| } | ||
| }, | ||
| "defaultName": "AndroidTest1" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense going to android-tools? and use that nupkg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should open a PR here to test out any new Adb APIs from dotnet/android-tools. None are merged yet, right?
It would be proof the new APIs work, though.