Skip to content

[Xamarin.Build.Download] Prevent interactive 7-Zip extraction hangs #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathanpeppers wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −1
Open

[Xamarin.Build.Download] Prevent interactive 7-Zip extraction hangs #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d844705
Fix interactive 7-Zip extraction hang
jonathanpeppers Jul 23, 2026
37a2f1e
Improve 7-Zip argument test diagnostics
jonathanpeppers Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions util/Xamarin.Build.Download/source/Xamarin.Build.Download.Tests/Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.IO;
using System.IO.Compression;
using System.Linq;
using System.Reflection;
using System.Xml;
using System.Xml.Linq;
using Microsoft.Build.Construction;
Expand Down Expand Up @@ -157,6 +158,27 @@ public void TestTgzDownload ()
Assert.True (File.Exists (Path.Combine (unpackDir, "GoogleSymbolUtilities-1.0.3", "Libraries", "libGSDK_Overload.a")));
}

[Fact]
public void Test7ZipExtractionIsNonInteractive ()
{
var method = typeof (Xamarin.Build.Download.XamarinDownloadArchives).GetMethod (
"Build7ZipExtractionArgs",
BindingFlags.NonPublic | BindingFlags.Static);
Assert.True (method != null, "Could not find XamarinDownloadArchives.Build7ZipExtractionArgs via reflection.");
var sevenZipPath = Path.Combine (TempDir, "7z.exe");
File.WriteAllText (sevenZipPath, string.Empty);

var args = method.Invoke (null, new object [] {
"archive.tgz",
TempDir,
sevenZipPath,
false,
null,
});

Assert.Contains ("-y", args.ToString ());
}

[Fact]
public void TestUncompressedNamedDownload ()
{
Expand Down
2 changes: 1 addition & 1 deletion util/Xamarin.Build.Download/source/Xamarin.Build.Download/Xamarin.Build.Download.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PackageId>Xamarin.Build.Download</PackageId>
<Title>Xamarin Build-time Download Support</Title>
<PackageVersion>0.11.4</PackageVersion>
<PackageVersion>0.11.5</PackageVersion>
<Authors>Microsoft</Authors>
<Owners>Microsoft</Owners>
<PackageProjectUrl>https://go.microsoft.com/fwlink/?linkid=865061</PackageProjectUrl>
Expand Down
3 changes: 3 additions & 0 deletions util/Xamarin.Build.Download/source/Xamarin.Build.Download/XamarinDownloadArchives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,9 @@ static ProcessArgumentBuilder Build7ZipExtractionArgs (string file, string conte
if (ignoreTarSymLinks)
args.Add ("-snl-");

// Never let 7-Zip wait for input from a non-interactive MSBuild task.
// https://7-zip.opensource.jp/chm/cmdline/switches/yes.htm
args.Add ("-y");
args.AddQuoted ("-o" + contentDir);
args.AddQuoted (file);
return args;
Expand Down