better perf by avoiding redundant casts#4018
Open
SimonCropp wants to merge 2 commits intodotnet:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs small, targeted micro-optimizations across SqlClient hot paths by replacing repeated is checks + explicit casts with C# pattern matching (is T t) to avoid redundant casts/unboxing and simplify code.
Changes:
- Replace
if (x is T) { (T)x ... }patterns withif (x is T t) { t ... }in multiple locations. - Simplify a couple of
ConvertTo(...)TypeConverter implementations by combining type checks and casts. - Minor readability cleanup in exception handling and bulk-copy XML handling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParser.cs | Uses pattern-matching locals to avoid repeated casts/unboxing while writing/serializing values (RPC params, bulk copy, and serialization paths). |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs | Simplifies SqlException detection/cast when building error arrays. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameter.cs | TypeConverter ConvertTo now pattern-matches SqlParameter once before calling instance descriptor conversion. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs | TypeConverter ConvertTo now pattern-matches SqlConnectionStringBuilder before instance descriptor conversion. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.cs | Avoids duplicate cast by binding SqlString via pattern matching in ANSI size computation logic. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs | Avoids duplicate cast when converting XmlReader to XmlDataFeed for XML/JSON bulk copy values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.