Skip to content

Test | Convert TvpQueryHintsTests to xunit assertions.#4002

Open
mdaigle wants to merge 4 commits intomainfrom
dev/mdaigle/convert-tvp-query-hints-tests
Open

Test | Convert TvpQueryHintsTests to xunit assertions.#4002
mdaigle wants to merge 4 commits intomainfrom
dev/mdaigle/convert-tvp-query-hints-tests

Conversation

@mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Mar 5, 2026

Refactors the TVP query hints tests to replace the legacy baseline-based test with modern, assertion-based tests. Removes baseline files and the shared TvpTest helper.

Copilot AI review requested due to automatic review settings March 5, 2026 18:05
@mdaigle mdaigle requested a review from a team as a code owner March 5, 2026 18:05
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mdaigle mdaigle force-pushed the dev/mdaigle/convert-tvp-query-hints-tests branch from dc9420b to 3bd09ad Compare March 5, 2026 18:59
Copilot AI review requested due to automatic review settings March 5, 2026 19:25
@mdaigle mdaigle force-pushed the dev/mdaigle/convert-tvp-query-hints-tests branch from 3bd09ad to 8295a3a Compare March 5, 2026 19:25
@mdaigle mdaigle force-pushed the dev/mdaigle/convert-tvp-query-hints-tests branch from 8295a3a to af1f0f1 Compare March 5, 2026 21:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.03%. Comparing base (3303d80) to head (af1f0f1).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3303d80) and HEAD (af1f0f1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3303d80) HEAD (af1f0f1)
CI-SqlClient 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4002      +/-   ##
==========================================
- Coverage   74.38%   65.03%   -9.36%     
==========================================
  Files         287      282       -5     
  Lines       43982    66073   +22091     
==========================================
+ Hits        32717    42971   +10254     
- Misses      11265    23102   +11837     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 65.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski self-assigned this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

3 participants