7.0 vite - #467
Open
GeorgeCatalinStan wants to merge 6 commits into
Open
Conversation
added 3 commits
June 17, 2026 10:59
# Conflicts: # src/App/assets/js/components/_main.js # src/App/assets/js/components/_table_settings.js
Qodana for JSIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
alexmerlin
requested changes
Aug 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 7.0 #467 +/- ##
=========================================
Coverage 38.53% 38.53%
Complexity 925 925
=========================================
Files 169 169
Lines 3768 3768
=========================================
Hits 1452 1452
Misses 2316 2316 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexmerlin
requested changes
Aug 12, 2026
alexmerlin
left a comment
alexmerlin
left a comment
Member
There was a problem hiding this comment.
I see a couple of issues with the JS files generated by the build:
- they are not minified+uglified
- they seem to contain both the JS content and a base64 dump of the JS content plaed at the end of each file (it looks similar to the JS .map files generated by other libraries)
//# sourceMappingURL=data:application/json;charset=utf-8;base64,...Similar issue with the CSS file generated by the build:
- it is not minified
Member
|
Everything seems to work as expected in the Admin. For example, this is the output of the > admin@2.0.0 prod
> vite build
vite v8.2.1 building client environment for production...
Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
╷
1 │ @import 'bootstrap/scss/bootstrap';
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/index.scss 1:9 root stylesheet
Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
╷
2 │ @import "settings";
│ ^^^^^^^^^^
╵
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
╷
3 │ @import "tools";
│ ^^^^^^^
╵
src/App/assets/scss/index.scss 3:9 root stylesheet
Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
╷
4 │ @import "utils";
│ ^^^^^^^
╵
src/App/assets/scss/index.scss 4:9 root stylesheet
Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
╷
5 │ @import "components";
│ ^^^^^^^^^^^^
╵
src/App/assets/scss/index.scss 5:9 root stylesheet
Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.
More info and automated migrator: https://sass-lang.com/d/import
╷
74 │ $inverse-danger : lighten($default-danger, 35%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 74:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [color-functions]: lighten() is deprecated. Suggestions:
color.scale($color, $lightness: 91.5384615385%)
color.adjust($color, $lightness: 35%)
More info: https://sass-lang.com/d/color-functions
╷
74 │ $inverse-danger : lighten($default-danger, 35%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 74:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.
More info and automated migrator: https://sass-lang.com/d/import
╷
75 │ $inverse-info : lighten($default-info, 45%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 75:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [color-functions]: lighten() is deprecated. Suggestions:
color.scale($color, $lightness: 89.2996108949%)
color.adjust($color, $lightness: 45%)
More info: https://sass-lang.com/d/color-functions
╷
75 │ $inverse-info : lighten($default-info, 45%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 75:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.
More info and automated migrator: https://sass-lang.com/d/import
╷
76 │ $inverse-primary : lighten($default-primary, 30%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 76:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [color-functions]: lighten() is deprecated. Suggestions:
color.scale($color, $lightness: 93.8650306748%)
color.adjust($color, $lightness: 30%)
More info: https://sass-lang.com/d/color-functions
╷
76 │ $inverse-primary : lighten($default-primary, 30%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 76:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.
More info and automated migrator: https://sass-lang.com/d/import
╷
77 │ $inverse-success : lighten($default-success, 45%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 77:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [color-functions]: lighten() is deprecated. Suggestions:
color.scale($color, $lightness: 90%)
color.adjust($color, $lightness: 45%)
More info: https://sass-lang.com/d/color-functions
╷
77 │ $inverse-success : lighten($default-success, 45%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 77:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.
More info and automated migrator: https://sass-lang.com/d/import
╷
78 │ $inverse-warning : lighten($default-warning, 45%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 78:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Deprecation Warning [color-functions]: lighten() is deprecated. Suggestions:
color.scale($color, $lightness: 90%)
color.adjust($color, $lightness: 45%)
More info: https://sass-lang.com/d/color-functions
╷
78 │ $inverse-warning : lighten($default-warning, 45%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
src/App/assets/scss/settings/baseColors.scss 78:25 @import
src/App/assets/scss/settings/index.scss 4:9 @import
src/App/assets/scss/index.scss 2:9 root stylesheet
Warning: 59 repetitive deprecation warnings omitted.
Run in verbose mode to see all warnings.
✓ 80 modules transformed.
[vite-plugin-static-copy] Copied 312 items.
computing gzip size...
public/fonts/themify.woff 56.10 kB
public/fonts/fontawesome-webfont.woff2 66.62 kB
public/fonts/fontawesome-webfont.eot 70.80 kB
public/fonts/themify.ttf 78.55 kB
public/fonts/themify.eot 78.72 kB
public/fonts/fontawesome-webfont.woff 83.58 kB
public/fonts/fontawesome-webfont.ttf 142.04 kB
public/fonts/themify.svg 234.26 kB │ gzip: 74.41 kB
public/fonts/fontawesome-webfont.svg 365.61 kB │ gzip: 110.52 kB
public/css/app.css 982.19 kB │ gzip: 112.10 kB
public/js/admin.js 1.87 kB │ gzip: 0.55 kB
public/js/table_settings.js 2.26 kB │ gzip: 0.87 kB
public/js/user.js 2.53 kB │ gzip: 0.74 kB
public/js/jquery.module.js 78.43 kB │ gzip: 27.78 kB
public/js/app.js 424.35 kB │ gzip: 139.90 kB
✓ built in 4.33s
[PLUGIN_TIMINGS] Your build spent 96% of 4.3s inside plugin hooks (4.2s).
Measured inside the callback, so queue time is excluded and time the callback itself awaited is not:
- vite:css transform (90%, 3.9s, 1 call)
See https://rolldown.rs/reference/InputOptions.checks#plugintimings for more details.@arhimede Should this PR address those deprecations as well? |
Member
|
@GeorgeCatalinStan that way we have few years until the next major upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transition from Webpack to VITE