Conversation
Signed-off-by: bota <Bota@dotkernel.com>
Qodana for JSIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
alexmerlin
left a comment
There was a problem hiding this comment.
Although it's beyond the scope of this feature, let's also sync these files:
Core\Admin\Entity\AdminLoginCore\App\Service\IpService
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: bota <Bota@dotkernel.com>
alexmerlin
left a comment
There was a problem hiding this comment.
Core\App\Service\IpService still needs some cosmetic modifications - just copy the file contents over from API, then they should be identical.
Signed-off-by: bota <Bota@dotkernel.com>
|
Synchronized the classes, but had to patch some PHPStan issues in Admin. Wouldn't it be better to fix the method signature in the source class (both Admin and API) instead of patching where is called? |
If you mean the changes you had to add in your last commit, they were to be fixed only in the Admin project because those files ( |
Signed-off-by: bota <Bota@dotkernel.com>
No description provided.