Skip to content

Issue #423: Upgraded mezzio-oauth2 to v3.0.1#424

Merged
arhimede merged 5 commits into7.0from
issue-423
May 4, 2026
Merged

Issue #423: Upgraded mezzio-oauth2 to v3.0.1#424
arhimede merged 5 commits into7.0from
issue-423

Conversation

@SergiuBota1
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: bota <Bota@dotkernel.com>
@SergiuBota1 SergiuBota1 linked an issue Apr 29, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Copy Markdown
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's beyond the scope of this feature, let's also sync these files:

  • Core\Admin\Entity\AdminLogin
  • Core\App\Service\IpService

Comment thread src/Core/src/Security/src/Entity/OAuthAuthCode.php Outdated
Comment thread src/Core/src/Security/src/Repository/OAuthScopeRepository.php Outdated
Comment thread src/Core/src/User/src/Entity/User.php Outdated
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: bota <Bota@dotkernel.com>
@SergiuBota1 SergiuBota1 requested a review from alexmerlin April 30, 2026 10:12
Copy link
Copy Markdown
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core\App\Service\IpService still needs some cosmetic modifications - just copy the file contents over from API, then they should be identical.

Signed-off-by: bota <Bota@dotkernel.com>
@SergiuBota1
Copy link
Copy Markdown
Member Author

Synchronized the classes, but had to patch some PHPStan issues in Admin. Wouldn't it be better to fix the method signature in the source class (both Admin and API) instead of patching where is called?

@SergiuBota1 SergiuBota1 requested a review from alexmerlin April 30, 2026 13:22
Comment thread src/Core/src/App/src/Service/IpService.php Outdated
Comment thread src/Core/src/App/src/Service/IpService.php Outdated
Comment thread src/Core/src/App/src/Service/IpService.php
@alexmerlin
Copy link
Copy Markdown
Member

Synchronized the classes, but had to patch some PHPStan issues in Admin. Wouldn't it be better to fix the method signature in the source class (both Admin and API) instead of patching where is called?

If you mean the changes you had to add in your last commit, they were to be fixed only in the Admin project because those files (src/Admin/src/Service/AdminLoginService.php and test/Unit/App/Service/IpServiceTest.php) are Admin-specific, not present in the API.
Only src/Core/src/App/src/Service/IpService.php is common between the two projects, so it's natural that we sync the code from the API to the Admin.

Signed-off-by: bota <Bota@dotkernel.com>
@arhimede arhimede merged commit 04ac07d into 7.0 May 4, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sync with API v 7.1

3 participants