Correctly set dep of client-preset, fix publishing#10848
Conversation
🦋 Changeset detectedLatest commit: 7daad35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8075d1a to
db3639b
Compare
5b0de03 to
64dfe3f
Compare
2cba2a4 to
3fb244f
Compare
💻 Website PreviewThe latest changes are available as preview in: https://pr-10848.graphql-code-generator.pages.dev |
There was a problem hiding this comment.
Pull request overview
Updates the monorepo to use workspace-linked dependencies for local development/builds (notably in the website and CLI), adjusts a dependency range in client-preset, and restructures GitHub Actions workflows to move snapshot/stable publishing into a dedicated release workflow (using pnpm).
Changes:
- Switch
website(and lockfile) to consume@graphql-codegen/cliand@graphql-codegen/client-presetviaworkspace:*. - Relax
@graphql-codegen/client-preset’s@graphql-codegen/gql-tag-operationsdependency from a fixed version to^6.0.0, and set the CLI to depend onclient-presetviaworkspace:^. - Replace the legacy release workflow with a new
release.yamlthat runs snapshot releases on PRs and stable releases on pushes.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| website/package.json | Uses workspace dependencies for local CLI/client-preset integration. |
| pnpm-lock.yaml | Reflects workspace linking + dependency range updates. |
| packages/presets/client/package.json | Changes @graphql-codegen/gql-tag-operations to ^6.0.0. |
| packages/graphql-codegen-cli/package.json | Switches @graphql-codegen/client-preset dependency to workspace:^. |
| .github/workflows/release.yml | Removes the previous stable-release workflow definition. |
| .github/workflows/release.yaml | Adds snapshot + stable release workflow using shared reusable workflows. |
| .github/workflows/pr.yml | Removes embedded snapshot publishing jobs; keeps dependency workflow. |
| .changeset/legal-cobras-hang.md | Adds a patch changeset for client-preset. |
| .changeset/@graphql-codegen_client-preset-10848-dependencies.md | Adds a dependency-update changeset for client-preset. |
| .changeset/@graphql-codegen_cli-10848-dependencies.md | Adds a dependency-update changeset for CLI. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:40
- Same issue here:
npmTokenis set toFILLER. Stable releases will fail to authenticate/publish unless this is replaced with a real secret (e.g.secrets.NPM_TOKEN) or removed if truly unused.
releaseScript: release
nodeVersion: 24
secrets:
githubToken: ${{ secrets.GITHUB_TOKEN }}
npmToken: FILLER
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
521001e to
7daad35
Compare
Description