Skip to content

Correctly set dep of client-preset, fix publishing#10848

Open
eddeee888 wants to merge 5 commits into
masterfrom
test-publishing
Open

Correctly set dep of client-preset, fix publishing#10848
eddeee888 wants to merge 5 commits into
masterfrom
test-publishing

Conversation

@eddeee888
Copy link
Copy Markdown
Collaborator

@eddeee888 eddeee888 commented May 25, 2026

Description

  • Correctly set deps pinning of client-preset
  • Also test publishing with pnpm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 25, 2026

🦋 Changeset detected

Latest commit: 7daad35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/cli Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eddeee888 eddeee888 force-pushed the test-publishing branch 2 times, most recently from 2cba2a4 to 3fb244f Compare May 25, 2026 14:12
@eddeee888 eddeee888 changed the title Correctly set dep of client-preset Correctly set dep of client-preset, fix publishing May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-10848.graphql-code-generator.pages.dev

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the monorepo to use workspace-linked dependencies for local development/builds (notably in the website and CLI), adjusts a dependency range in client-preset, and restructures GitHub Actions workflows to move snapshot/stable publishing into a dedicated release workflow (using pnpm).

Changes:

  • Switch website (and lockfile) to consume @graphql-codegen/cli and @graphql-codegen/client-preset via workspace:*.
  • Relax @graphql-codegen/client-preset’s @graphql-codegen/gql-tag-operations dependency from a fixed version to ^6.0.0, and set the CLI to depend on client-preset via workspace:^.
  • Replace the legacy release workflow with a new release.yaml that runs snapshot releases on PRs and stable releases on pushes.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
website/package.json Uses workspace dependencies for local CLI/client-preset integration.
pnpm-lock.yaml Reflects workspace linking + dependency range updates.
packages/presets/client/package.json Changes @graphql-codegen/gql-tag-operations to ^6.0.0.
packages/graphql-codegen-cli/package.json Switches @graphql-codegen/client-preset dependency to workspace:^.
.github/workflows/release.yml Removes the previous stable-release workflow definition.
.github/workflows/release.yaml Adds snapshot + stable release workflow using shared reusable workflows.
.github/workflows/pr.yml Removes embedded snapshot publishing jobs; keeps dependency workflow.
.changeset/legal-cobras-hang.md Adds a patch changeset for client-preset.
.changeset/@graphql-codegen_client-preset-10848-dependencies.md Adds a dependency-update changeset for client-preset.
.changeset/@graphql-codegen_cli-10848-dependencies.md Adds a dependency-update changeset for CLI.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/release.yaml:40

  • Same issue here: npmToken is set to FILLER. Stable releases will fail to authenticate/publish unless this is replaced with a real secret (e.g. secrets.NPM_TOKEN) or removed if truly unused.
      releaseScript: release
      nodeVersion: 24
    secrets:
      githubToken: ${{ secrets.GITHUB_TOKEN }}
      npmToken: FILLER

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yaml
Comment thread .github/workflows/release.yaml
Comment thread .github/workflows/release.yaml
Comment thread .github/workflows/pr.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants