Skip to content

Make dev-test project (2)#10837

Open
eddeee888 wants to merge 7 commits into
masterfrom
dev-test-project-2
Open

Make dev-test project (2)#10837
eddeee888 wants to merge 7 commits into
masterfrom
dev-test-project-2

Conversation

@eddeee888
Copy link
Copy Markdown
Collaborator

@eddeee888 eddeee888 commented May 17, 2026

Description

Follow-up for #10836

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 17, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: d741a1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eddeee888 eddeee888 mentioned this pull request May 17, 2026
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://pr-10837.graphql-code-generator.pages.dev

eddeee888
eddeee888 commented May 25, 2026
View reviewed changes
Comment thread .prettierignore
Comment on lines -39 to -40
dev-test/general/githunt-invalid/invalid.graphql
dev-test/general/test-schema/flow-types.flow.js
Copy link
Copy Markdown
Collaborator Author

@eddeee888 eddeee888 May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to dev-test/general/.prettierignore to be correctly scoped

eddeee888
eddeee888 commented May 25, 2026
View reviewed changes
Comment thread package.json
Comment on lines -43 to -53
"@graphql-codegen/add": "workspace:*",
"@graphql-codegen/cli": "workspace:*",
"@graphql-codegen/client-preset": "workspace:*",
"@graphql-codegen/flow": "3.0.1",
"@graphql-codegen/flow-resolvers": "3.0.2",
"@graphql-codegen/graphql-modules-preset": "workspace:*",
"@graphql-codegen/typed-document-node": "workspace:*",
"@graphql-codegen/typescript": "workspace:*",
"@graphql-codegen/typescript-graphql-files-modules": "4.0.1",
"@graphql-codegen/typescript-operations": "workspace:*",
"@graphql-codegen/typescript-resolvers": "workspace:*",
Copy link
Copy Markdown
Collaborator Author

@eddeee888 eddeee888 May 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to CLI as a hack (from this root-level project hack 😬)

This implementation seems to incorrectly resolve files for ESM packages.

When using relativeRequire.resolve(mod) with ESM, it seems to work though, so we will come back and release a new version for that change

@eddeee888 eddeee888 force-pushed the dev-test-project-2 branch from f267b7a to c44b36f Compare May 25, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eddeee888