CODEGEN-899 - Dedupe fragments when documentMode=graphQLTag#10554
Open
eddeee888 wants to merge 8 commits into
Open
CODEGEN-899 - Dedupe fragments when documentMode=graphQLTag#10554eddeee888 wants to merge 8 commits into
eddeee888 wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: a15dc9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-10554.graphql-code-generator.pages.dev |
eddeee888
force-pushed
the
dedupe-fragments
branch
from
7572bb1 to
8a1c3af
Compare
eddeee888
force-pushed
the
dedupe-fragments
branch
2 times, most recently
from
429ecee to
d0080ec
Compare
eddeee888
force-pushed
the
dedupe-fragments
branch
from
d0080ec to
2c18769
Compare
eddeee888
force-pushed
the
dedupe-fragments
branch
from
a797d89 to
3e57819
Compare
eddeee888
commented
May 25, 2026
| "dependencies": { | ||
| "@graphql-codegen/plugin-helpers": "^7.0.0", | ||
| "@graphql-codegen/visitor-plugin-common": "^7.0.0", | ||
| "@graphql-codegen/visitor-plugin-common": "workspace:^", |
Collaborator
Author
There was a problem hiding this comment.
We'll need to do this for other deps as well, will do in another PR to keep changes low here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We recently removed a deprecated
dedupeFragmentsconfig option here.However, I believe the intention was "to enable it by default, therefore the option is not required" 😅
This PR re-applies the deduping logic, without the need of an option. I've also added a test to demonstrate the behaviour for next time.
Related # #10551
Type of change
How Has This Been Tested?