Skip to content

Chore: Enable New Block Editor by Default#36257

Open
rjvelazco wants to merge 1 commit into
mainfrom
issue-36254-enable-block-editor-20-by-default
Open

Chore: Enable New Block Editor by Default#36257
rjvelazco wants to merge 1 commit into
mainfrom
issue-36254-enable-block-editor-20-by-default

Conversation

@rjvelazco

@rjvelazco rjvelazco commented Jun 22, 2026

Copy link
Copy Markdown
Member

This PR fixes: #36254

Remove feature flag for the new TipTap-v3 block editor.
@rjvelazco rjvelazco linked an issue Jun 22, 2026 that may be closed by this pull request
5 tasks
@github-actions github-actions Bot added the Area : Backend PR changes Java/Maven backend code label Jun 22, 2026
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🤖 Bedrock Review — deepseek.v3.2

[🟡 Medium] dotCMS/src/main/resources/dotmarketing-config.properties:867 — Removed feature flag FEATURE_FLAG_NEW_BLOCK_EDITOR without a clear migration or fallback plan. This could break existing functionality if the flag was actively used to toggle between old and new editors, leaving no way to revert.


Run: #27964517364 · tokens: in: 544 · out: 74 · total: 618

@claude

claude Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @rjvelazco's task in 1m 22s —— View job


Rollback Safety Analysis

  • Read rollback-unsafe categories reference
  • Get full PR diff
  • Analyze diff against unsafe categories
  • Apply label

Result: ✅ Safe To Rollback

The diff removes 3 lines from dotCMS/src/main/resources/dotmarketing-config.properties:

-## New TipTap-v3 Block Editor (rollback safety: legacy editor renders by default)
-FEATURE_FLAG_NEW_BLOCK_EDITOR=false
-

Checked against all unsafe categories:

Category Match?
C-1 Structural Data Model Change ✅ No
C-2 Elasticsearch Mapping Change ✅ No
C-3 Content JSON Model Version Bump ✅ No
C-4 DROP TABLE / DROP Column ✅ No
H-1 One-Way Data Migration ✅ No
H-2 RENAME TABLE/COLUMN ✅ No
H-3 PK Restructuring ✅ No
H-4 New Field Type ✅ No
H-5 Storage Provider Change ✅ No
H-6 DROP PROCEDURE/FUNCTION ✅ No
H-7 NOT NULL Column Without Default ✅ No
H-8 VTL Viewtool Contract Change ✅ No
M-1 Column Type Change ✅ No
M-2 Push Publishing Bundle Format ✅ No
M-3 REST/GraphQL API Contract ✅ No
M-4 OSGi Plugin API Breakage ✅ No

This is a pure config property removal with no database, Elasticsearch, API, or storage impact. Removing the feature flag means the block editor behavior is now unconditional (always enabled), but rolling back to N-1 is fully safe — N-1 still has the flag definition and will simply read its default value (false) as before.

Label applied: AI: Safe To Rollback

@rjvelazco rjvelazco marked this pull request as ready for review June 22, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI: Safe To Rollback Area : Backend PR changes Java/Maven backend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Enable Block Editor 2.0 by default

1 participant