33073 upgrade rxjs from v6 to v7 local #34093
Draft
+1,805
−1,253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-code-dotcms-test[bot]](https://avatars.githubusercontent.com/u/1005263?s=60&v=4){kind=small}
| @@ -19172,9 +19237,9 @@ node-fetch@cjs: | |||
| whatwg-url "^5.0.0" | |||
|
|
|||
| node-forge@^1: | |||
There was a problem hiding this comment.
Legal Risk
node-forge 1.3.3 was released under the GPL-2.0 license, a license that
has been flagged by your organization for consideration.
Recommendation
While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.
…onse type ### Changes Made - Updated various services to utilize the `DotCMSResponse` type for better type safety and consistency in response handling. - Adjusted the mapping logic in multiple service methods to correctly extract the `entity` from the response. ### Impact This refactor improves the maintainability and readability of the code by ensuring that all API responses are handled uniformly across the application. This PR addresses issues related to type safety in API interactions.
…nd clean up tsconfig.json by removing skipLibCheck option
…ting line breaks for better code clarity.
…otCMS/core into 33073-upgrade-rxjs-from-v6-to-v7-local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots