Let the release workflow build on a fresh agent, and keep data attributes out of the site check - #15
Merged
Merged
Conversation
The first run of the release workflow stopped before building anything: build-dist.ps1 asked where NuGet keeps its packages before the loop, and on a fresh build agent that folder does not exist until the first restore creates it. Every local run passed because a machine that has built anything before already has it. The question now comes at the step that needs the answer, after the publish, which restores. Run locally against an empty package folder the old script stops with the same sentence as the agent did, and this one builds both archives, checks the pinned bytes and writes the bill of materials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A word boundary also stands between the hyphen and the name in data-src and data-href, so their values were read as addresses, and a value that is not a path would have failed a strict build and with it the website. The pattern now wants whitespace before the name. On today's site it still finds the same 873 addresses. The test for a malformed address looked for the address alone, which the relative-address sentence prints too, so it passed whether or not the scheme was recognised. It now looks for the sentence of its own branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two fixes, both found before the
v0.2.0tag.The release workflow could not have built anything on its first run
release.ymlfrommainstopped inpackaging/build-dist.ps1with "the global package folder ... is not there".The site check read
data-srcanddata-hrefas addresses (review of #14)data-src. The pattern now wants whitespace before the attribute name.How it was checked
build-dist.ps1was run locally against an empty package folder (NUGET_PACKAGESpointed at a new directory).SHA256SUMS.A_data_attribute_is_not_read_as_an_addresswas red before the fix and is green after it.tests/Bws.Site.Testspasses 26 of 26.tests/Bws.Architecture.Testspasses 182 of 182. The site builds with--strictand reports no problems.After this merges, the release workflow is run once more from
mainbefore the tag, to see the build step pass on an agent.🤖 Generated with Claude Code
Summary by CodeRabbit
data-hrefanddata-srcvalues, preventing non-link attributes from being reported as addresses.