-
-
Notifications
You must be signed in to change notification settings - Fork 238
Fix datetime functions to return correct results for 0 and false
#3305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o angela/date_functions
…-mysql-server into angela/date_functions
…-mysql-server into angela/date_functions
jycor
reviewed
Nov 17, 2025
jycor
approved these changes
Nov 17, 2025
Contributor
jycor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#10075
Our datetime functions were not returning the correct results for
0andfalse. This was because we were using0000-01-01aszeroTime(which evaluates to true using Go'stime.IsZero) and then extracting datetime information from that timestamp. Using0000-01-01aszeroTimewas also giving incorrect results for some functions when the input timestamp was actually0000-01-01, since it was being equated aszeroTime.Also, depending on whether
falsewas read asfalseor0, we were also not able to convert it tozeroTime.This fix involves updating
zeroTimetotime.Date(0, 0, 0, 0, 0, 0, 0, time.UTC), which has the timestamp-0001-11-30. Since negative years are not valid in MySQL, this timestamp would not conflict with a non-zero timestamp. We also add in checks forzeroTimeto make sure functions return the correct value fromzeroTimeinstead of simply extracting datetime information from the timestamp.Dolt bump PR: dolthub/dolt#10084