Repository navigation
Fix macOS shim cache reuse and atomic publication - #3
Merged
Merged
Conversation
Use a stable digest of the resolved library path, mtime, and SQLite install name. Patch a private staging copy and atomically replace the cached shim so failed or concurrent builds cannot expose an unfinished library. Cover cross-process reuse, invalidation, failure cleanup, and concurrent starts in CI. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every macOS interpreter start used a process-randomized cache key, copying and patching another library. Concurrent starts could also reuse a shim before copying or patching finished.
Use a stable SHA-256 key over the resolved library path, modification time, and target install name. Build in a private temporary directory, then publish with an atomic rename. Failed builds leave no cached library to poison a retry.
Validation:
Fixes #2
Co-Authored-By: OpenAI Codex noreply@openai.com