Skip to content

[no-release-notes] Update pg catalog join test#2853

Draft
angelamayxie wants to merge 1 commit into
mainfrom
angela/filter_bump
Draft

[no-release-notes] Update pg catalog join test#2853
angelamayxie wants to merge 1 commit into
mainfrom
angela/filter_bump

Conversation

@angelamayxie

Copy link
Copy Markdown
Contributor

Depends on dolthub/go-mysql-server#3591

Since we are no longer pushing filters into the join condition, the query plan has changed.

Furthermore, filters are now getting pushed down to the table node level. Filters were previously not getting pushed down to the table node level in Doltgres since GMS's expression.SplitConjunction does not recognize GMSCast expressions, which wrap And expressions. dolthub/go-mysql-server#3591 uses analyzer.SplitConjunction instead, which gets replaced in Doltgres with a version of SplitConjunction that handles GMSCast expressions.

@github-actions

Copy link
Copy Markdown
Contributor
Main PR
covering_index_scan_postgres 1744.93/s 1864.00/s +6.8%
groupby_scan_postgres 134.07/s 133.82/s -0.2%
index_join_postgres 638.49/s 644.90/s +1.0%
index_join_scan_postgres 778.07/s 777.45/s -0.1%
index_scan_postgres 24.55/s 24.20/s -1.5%
oltp_delete_insert_postgres 788.84/s 795.17/s +0.8%
oltp_insert 682.93/s 670.80/s -1.8%
oltp_point_select 2783.03/s 2806.94/s +0.8%
oltp_read_only 2881.01/s 2854.10/s -1.0%
oltp_read_write 2260.06/s 2256.89/s -0.2%
oltp_update_index 712.59/s 712.16/s -0.1%
oltp_update_non_index 746.97/s 745.67/s -0.2%
oltp_write_only 1698.86/s 1705.42/s +0.3%
select_random_points 1824.74/s 1816.34/s -0.5%
select_random_ranges 1047.92/s 1051.91/s +0.3%
table_scan_postgres 22.92/s 22.63/s -1.3%
types_delete_insert_postgres 748.91/s 756.76/s +1.0%
types_table_scan_postgres 8.12/s 8.07/s -0.7%

@github-actions

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 18270 18270
Failures 23820 23820
Partial Successes1 5334 5334
Main PR
Successful 43.4070% 43.4070%
Failures 56.5930% 56.5930%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant