[no-release-notes] Update pg catalog join test#2853
Draft
angelamayxie wants to merge 1 commit into
Draft
Conversation
Contributor
|
Contributor
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on dolthub/go-mysql-server#3591
Since we are no longer pushing filters into the join condition, the query plan has changed.
Furthermore, filters are now getting pushed down to the table node level. Filters were previously not getting pushed down to the table node level in Doltgres since GMS's
expression.SplitConjunctiondoes not recognizeGMSCastexpressions, which wrapAndexpressions. dolthub/go-mysql-server#3591 usesanalyzer.SplitConjunctioninstead, which gets replaced in Doltgres with a version ofSplitConjunctionthat handlesGMSCastexpressions.