Skip to content

Add Docker CI rollout baseline#3

Open
ohmyfelix wants to merge 3 commits into
dockette:masterfrom
ohmyfelix:chore/ci-rollout-baseline
Open

Add Docker CI rollout baseline#3
ohmyfelix wants to merge 3 commits into
dockette:masterfrom
ohmyfelix:chore/ci-rollout-baseline

Conversation

@ohmyfelix

Copy link
Copy Markdown
Contributor

What changed

  • Added the standard Dockette Docker workflow with Test, Build, and Docs jobs.
  • Added Makefile build, test, and run targets with dry-run shell/config smoke checks only.
  • Normalized README badges to the dockette/copybara style and added repo-local AGENTS/CLAUDE instructions.

Why

  • Establishes the Dockette CI rollout baseline for dockette/letsencrypt without making real ACME or Let's Encrypt calls in CI.

ohmyfelix and others added 2 commits June 5, 2026 10:21
@ohmyfelix ohmyfelix force-pushed the chore/ci-rollout-baseline branch from c40635c to 0cb6d59 Compare June 5, 2026 11:45
@f3l1x

f3l1x commented Jun 16, 2026

Copy link
Copy Markdown
Member

Suggested change: run CI on PRs, but keep publish strictly master-only

Right now this workflow has no pull_request trigger, so the Test job never validates the PR — and the publish (Build) job calls the reusable workflow with secrets: inherit with no master guard. Adding pull_request without guarding the publish job would expose registry secrets on every PR.

Two changes fix both:

 on:
   workflow_dispatch:
+
+  pull_request:

   push:
     branches: ["master"]
@@
   build:
     name: "Build"
     needs: ["test"]
+    if: github.ref == 'refs/heads/master'
     uses: dockette/.github/.github/workflows/docker.yml@master
     secrets: inherit

Result: a PR runs only the Test job (builds the image locally with load: true, runs make test, no secrets); Build (publish) and Docs run only on master. This matches the canonical shape already used in dockette/mockbin#2 and dockette/perl#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants