feat: add ErrorTransformer for llama.cpp#729
Merged
doringeman merged 1 commit intodocker:mainfrom Mar 4, 2026
Merged
Conversation
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an ErrorTransformer for the llama.cpp backend to improve error reporting. A new errors.go file defines regular expressions to catch common llama.cpp errors and replace them with more user-friendly messages. This is accompanied by unit tests in errors_test.go. The new error transformer is then integrated into the main llama.cpp backend logic. The changes are well-structured and effectively address the goal of providing clearer error feedback to users.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the regex patterns slightly more robust (e.g., using case-insensitive flags or matching just the key terms like
failed to allocate buffer/out of memory) so they continue to work if upstream log wording changes slightly. - Returning the full stderr output when no pattern matches may surface very noisy logs to the user; you might want to truncate or sanitize the fallback message, or prepend a short generic summary and include the raw output only for debugging.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the regex patterns slightly more robust (e.g., using case-insensitive flags or matching just the key terms like `failed to allocate buffer` / `out of memory`) so they continue to work if upstream log wording changes slightly.
- Returning the full stderr output when no pattern matches may surface very noisy logs to the user; you might want to truncate or sanitize the fallback message, or prepend a short generic summary and include the raw output only for debugging.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ilopezluna
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ErrorTransformerforllama.cppto surface friendly error messages.E.g.,
Logs:
Improves UX for #709.