report invalid global expressions clearly#662
Open
crazy-max wants to merge 2 commits into
Open
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
validate-global-exp
branch
from
976e871 to
96d23fc
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves error reporting for unsupported global Handlebars expressions in metadata inputs, addressing cases where invalid helpers previously rendered as empty strings and produced misleading downstream validation errors.
Changes:
- Adds an allow-list check for global expressions in
setGlobalExp. - Throws a clearer error for unsupported global expression names.
- Adds a regression test for an invalid
enable={{is_prerelease}}expression.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/meta.ts |
Adds parsing and validation of global Handlebars expressions before compilation. |
__tests__/meta.test.ts |
Adds coverage for the new invalid global expression error path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+486
to
+492
| for (const node of template.body) { | ||
| const statement = node as {type: string; path?: {type: string; original: string}}; | ||
| if (statement.type !== 'MustacheStatement' || statement.path?.type !== 'PathExpression') { | ||
| continue; | ||
| } | ||
| if (!expressions.includes(statement.path.original)) { | ||
| throw new Error(`{{${statement.path.original}}} is not a valid global expression`); |
tonistiigi
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #545
Handlebars silently renders missing helpers as empty strings, which made configuration mistakes look like boolean parsing failures. Validating the expression name at the rendering boundary preserves existing behavior for documented expressions while producing a more useful error for unsupported ones.
The global expression map in
setGlobalExpnow doubles as the allowed expression list, and the parsed Handlebars template is checked inline before compilation.