Support profiles with Gordon and add profile manual-instructions
#272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR adds support for using Gordon with profiles. It also adds a hidden
docker mcp profile manual-instructions <profile-id>that we can use to display instructions in DD.In order to support profiles with Gordon, we write a profile to
~/.docker/mcp/profiles.json. Then when Gordon runs the hidden commanddocker mcp client manual-instructions --jsonit will use the Gordon profile written to that file to produce the mcp gateway run command. The fileprofiles.jsonhas no other use than that at the present time. (In the future we can consider refactoring configuration to be session-based rather than global to enable session-loaded profiles.)Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
