Add --no-tools to catalog show and server ls #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address issue where too much data was being printed when showing an entire catalog, introduce a option to specify --no-tools to exclude tools from the response. Additionally, add a `docker mcp catalog-next server ls` command so that we can get individual server information from a catalog that does include the tools.
Using --format json or yaml would return the entire contents of all the catalogs. Instead, return the data that is returned for human readable output.
bobbyhouse
force-pushed
the
mcpt-185-add-servers-from-catalog
branch
from
11a4ed8 to
3e01128
Compare
Daniel-Kolev
approved these changes
Dec 2, 2025
cmrigney
approved these changes
Dec 2, 2025
Contributor
cmrigney
left a comment
cmrigney
left a comment
There was a problem hiding this comment.
lgtm. Left a couple suggestions but we can follow up later.
| return outputServers(catalog.Ref, catalog.Title, servers, format) | ||
| } | ||
|
|
||
| func parseFilters(filters []string) ([]serverFilter, error) { |
Contributor
There was a problem hiding this comment.
thought (follow up later): I wonder if we can reuse some of the code we have in workingset/server.go.
Comment on lines
+80
to
+82
| if noTools { | ||
| catalog = filterCatalogTools(catalog) | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): I would personally find it more readable if we edit in-place to nil the values out instead of making a copy:
Suggested change
| if noTools { | |
| catalog = filterCatalogTools(catalog) | |
| } | |
| if noTools { | |
| for i := range catalog.Servers { | |
| catalog.Servers[i].Tools = nil | |
| if catalog.Servers[i].Snapshot != nil { | |
| catalog.Servers[i].Snapshot.Server.Tools = nil | |
| } | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
docker mcp catalog-next server lswith filtering options on the server name so that we can get the details of a single server, including all of it's toolsdocker mcp catalog-next showbecause we were returning too much data that would exceed a 1MB limit for node processes to for data over stdiodocker mcp catalog-next ls --format json/yamlreturn list data instead of all the data for all the catalogs, which would also exceed the 1MB limitRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did