Skip to content

Conversation

@fedordikarev
Copy link

Fix: #750

  • Retry only 5xx errors (502 for now) as dont need to retry bad login/passwords
  • Sleep 10s before attempts. It could be configurable, but shouldn't bit less than 10s.
  • Delay could be with exponential backoff, or just simple approach with no more than 3 attempts and constant 10s delay, IMO, should be enough for docker login

Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
@fedordikarev
Copy link
Author

hi @crazy-max !

what do you think about these changes?

@bayandin
Copy link

bayandin commented Jan 8, 2025

Hey @crazy-max and @offensive-vk,

Is there anything we can do to get this PR merged?
Or, if the PR suggests the way you wouldn't like to proceed, could you please let us know as well?

Thank you both and Happy New Year!

Co-authored-by: Michael Bowyer <mbowyer@umich.edu>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Copy link

@offensive-vk offensive-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@fedordikarev
Copy link
Author

well, I'm going to close that PR, as it's:

  1. first of all, it doesn't work :-)
  2. it was created when I had 15 minutes free time in the train
  3. so it's not perfect, not even good :-)
  4. and here is PR I did when I had more time and did it from home: Add moderate way to retry docker login failures #849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add retry

4 participants