dhi: env vars in customizations#25285
Open
craig-osterhout wants to merge 3 commits into
Open
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
craig-osterhout
added
status/review
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
docker-agent
reviewed
Jun 5, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR documents how environment variables from OCI artifacts are automatically merged into customized DHI images. The restructuring into a dedicated ## OCI artifacts section with subsections (create, environment variables, best practices) is clear and well-organized.
No high or medium severity issues found. The new content is accurate, readable, and follows the documentation style guide. A few minor low-severity observations (not blocking):
- The cross-reference sentence at line ~104 is slightly verbose; it could be trimmed to "For more details, see OCI artifacts."
- The intro sentence "This section covers..." is mild meta-commentary per the style guide — could be removed.
- Run-on sentence in the Environment variables subsection (line ~575) — minor readability concern.
- Colon-label bullet format ("Use multi-stage builds: ...") is borderline per style guide, but not bold so acceptable.
None of these are blocking issues.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documented how environment variables from OCI artifacts are automatically merged into customized DHI images.
Preview: https://deploy-preview-25285--docsdocker.netlify.app/dhi/how-to/customize/
Related issues or tickets
DXT-775
Reviews