sbx-cli: render experimental indicators for commands and flags#25279
Open
dvdksn wants to merge 4 commits into
Open
sbx-cli: render experimental indicators for commands and flags#25279dvdksn wants to merge 4 commits into
dvdksn wants to merge 4 commits into
Conversation
Mirrors the Docker CLI layout: commands with experimental: true get a magenta callout block, experimental flags get an amber badge in the options tables, and experimental subcommands get the badge in the Commands table. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
docker-agent
reviewed
Jun 5, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The changes add experimental visual indicators to the sbx-cli layout template, matching the established pattern in cli.html. The implementation is correct:
- Command-level indicator: Magenta callout block mirrors the
cli.htmlapproach forexperimental: trueat the YAML root - Flag-level badges: Amber
experimentalbadge matches the existingcli.htmlusage for experimental flags (both daemon and CLI experimental badges incli.htmluse amber — this PR intentionally replicates that pattern) - Subcommands table: Amber badge alongside the synopsis is consistent with the parent CLI layout
No vendored or generated files were modified. No redirects needed (no pages removed or moved). No AI-isms or style violations detected in the template text strings.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
craig-osterhout
approved these changes
Jun 5, 2026
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
lgtm
Noting that the chip in the title appears to be different than the existing cli layout:
https://deploy-preview-25279--docsdocker.netlify.app/reference/cli/docker/manifest/rm/
https://deploy-preview-25279--docsdocker.netlify.app/reference/cli/sbx/kit/add/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sbx-clilayout template had no handling for theexperimental: truefield present in manydata/sbx_cli/*.yamlfiles. This adds visual indicators matching the Docker CLI layout:experimental: trueat YAML root): magenta callout block below the summary tableexperimental: trueon an option): amber badge before the flag description in Options and Global options tablesGenerated by Claude Code