Conversation
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Review Summary
Assessment: 🔴 CRITICAL
This PR successfully updates most GitHub repository references from docker/cagent to docker/docker-agent, but there are critical incomplete renames in two files that were modified by this PR:
🔴 Critical Issues
1. .github/workflows/agent-writer.yml (line 28)
Incomplete rename: GitHub Action reference still uses old repo name
This file was modified to update the PR body text link (line 62), but the actual GitHub Action reference on line 28 still points to docker/cagent-action@latest. This should likely be updated to docker/docker-agent-action@latest or similar for consistency with the repository rename.
uses: docker/cagent-action@latest2. content/manuals/ai/docker-agent/reference/examples.md (line 15)
Incomplete rename: Shortcode still fetches from old repo URL
This file was modified to update the visible GitHub link (line 9), but the shortcode's $baseUrl variable on line 15 still points to the old repo. This will cause 404 errors when the shortcode tries to fetch example files:
{{- $baseUrl := "https://raw.githubusercontent.com/docker/cagent/refs/heads/main/examples" }}Should be:
{{- $baseUrl := "https://raw.githubusercontent.com/docker/docker-agent/refs/heads/main/examples" }}Additional References Not Updated (Not in Modified Files)
For completeness, here are other cagent references found in the repository that weren't updated (these are in files not modified by this PR):
.github/workflows/pr-review.yml:uses: docker/cagent-action/.github/workflows/review-pr.yml@latest.github/workflows/nightly-docs-scan.yml:uses: docker/cagent-action@latest.github/agents/docs-scanner.yaml:$schema=https://raw.githubusercontent.com/docker/cagent/refs/heads/main/cagent-schema.json
These may need to be addressed in a follow-up PR or may be intentionally left as-is if those actions haven't been renamed yet.
Note: This is a COMMENT-only review. The bot provides feedback but does not block merging.
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
|
Renamed the raw gh urls. |
Description
rename GH cagent repo URL, repo has been renamed to docker/docker-agent
Reviews