Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
area/compose
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This is an excellent refresh of the Compose getting started tutorial with better structure, modern examples, and progressive complexity. The new step-by-step approach covering health checks, watch mode, volumes, and multi-file composition is pedagogically sound.
However, there's one critical issue in Step 6 that will prevent the tutorial from working: the compose.yaml example is missing the include: directive needed to load infra.yaml.
There was a problem hiding this comment.
Review Summary
Found 2 critical issues that will prevent users from successfully completing Step 6 of the tutorial. Both are missing YAML configuration elements that are required for the example to work.
The rest of the refresh looks excellent - the new structure with progressive complexity (health checks → watch → volumes → multi-file) is much better than the original, and the addition of .env files and debugging commands are valuable improvements.
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
Looks good, just few nits to double checks
|
|
||
| Check the `Hello World` message in a web browser again, and refresh to see the | ||
| count increment. | ||
| The `watch` block defines two rules. The `sync+restart` action syncs any changes |
There was a problem hiding this comment.
This first sentence confused me at first. I'm not sure what it means about the changes under path: . into target: /code.
Is it saying that on save after updating code, docker compose can in-the-moment sync and update changes to Flask app w/o the additional step of updating in Redis first?
There was a problem hiding this comment.
I've rephrased! Let me know if this is clearer. I also added the following line at the top which perhaps frames watch better:
Without Compose Watch, every code change requires you to stop the stack, rebuild the image, and restart the containers. Compose Watch eliminates that cycle by automatically syncing changes into your running container as you save files.
3 participants
Description
Related issues or tickets
Reviews