fix(tui): make /speak slash command dispatch immediately#2496
Merged
dgageot merged 1 commit intodocker:mainfrom Apr 23, 2026
Merged
fix(tui): make /speak slash command dispatch immediately#2496dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
The /speak command was missing Immediate: true, so Parser.Parse silently ignored it and the input was forwarded to the agent as a regular message instead of starting speech-to-text transcription. Mark it Immediate like every other session slash command and add a darwin-only regression test. Assisted-By: docker-agent
rumpl
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Typing
/speakin the chat input did nothing — the text was silently forwarded to the agent as a regular message instead of starting speech-to-text transcription.Root cause
commands.Parser.Parseonly dispatches slash commands that haveImmediate: true:Every session slash command (
/clear,/new,/exit,/yolo, …) setsImmediate: true, butspeakCommandinpkg/tui/commands/speak_darwin.gowas missing the flag, so/speakfell through to the regular message path.Fix
Immediate: trueon the/speakcommand. Starting transcription is a local UI action that does not interrupt any ongoing stream, consistent with the other session slash commands.parser.Parse("/speak")returns a command that emitsStartSpeakMsg.Validation
go build ./...go test ./pkg/tui/commands/...mise lint