Make required variable reporting deterministic#13957
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ousama Ben Younes <benyounes.ousama@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Make Compose required-variable handling deterministic before project interpolation runs.
Related issue
Fixes #13712
Fixes #13718
Test verification (RED -> GREEN)
RED for #13712 on
origin/mainwith the issue repro run 20 times:GREEN for #13712 on this branch with the same repro:
RED for #13718 on
origin/main:{ "PIHOLE_DOMAIN": { "Name": "PIHOLE_DOMAIN", "DefaultValue": "", "PresenceValue": "", "Required": false } }GREEN for #13718 on this branch:
{ "PIHOLE_DOMAIN": { "Name": "PIHOLE_DOMAIN", "DefaultValue": "", "PresenceValue": "", "Required": true } }Full local suite: